Bug 165186

Summary:	REGRESSION (r209104): storage/indexeddb/modern/gc-closes-database(-private).html timeout
Product:	WebKit	Reporter:	Brady Eidson <beidson>
Component:	WebCore Misc.	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	cdumez
Priority:	P2
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	160306

Description Brady Eidson 2016-11-29 19:48:01 PST

REGRESSION (r209104): storage/indexeddb/modern/gc-closes-database(-private).html timeout

I know why.

209104 was meant to resolve a GuardMalloc issue, which it did, but it also introduced a leak.

I'll resolve both the leak and GuardMalloc issue at the same time in this bug.

Comment 1 Brady Eidson 2016-11-29 19:51:14 PST

Skipped the tests for now in https://trac.webkit.org/changeset/209114

Comment 2 Brady Eidson 2016-11-29 20:16:06 PST

I figured this out.

Comment 3 Brady Eidson 2016-11-29 20:29:43 PST

(In reply to comment #2)
> I figured this out.

Well, no... no I did not, I guess. Huh.

Comment 4 Chris Dumez 2016-11-29 20:37:36 PST

Reverted r209096, r209104, and r209114 for reason:

Caused over 200 layout test failures on the bots

Committed r209117: <http://trac.webkit.org/changeset/209117>

Comment 5 Brady Eidson 2016-11-29 23:21:46 PST

(In reply to comment #4)
> Reverted r209096, r209104, and r209114 for reason:
> 
> Caused over 200 layout test failures on the bots
> 
> Committed r209117: <http://trac.webkit.org/changeset/209117>

Have a link to that...?  (All EWS passed and I can't reproduce such failures locally...?)

Comment 6 Brady Eidson 2016-11-30 11:10:30 PST

With the rollouts last night and then https://trac.webkit.org/changeset/209132 this morning, this has been resolved.