Summary: | Web Inspector: Clicking on link in Web Inspector can cause UIProcess to crash | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, bburg, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2016-11-29 14:00:07 PST
Created attachment 295635 [details]
[PATCH] Proposed Fix
Comment on attachment 295635 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=295635&action=review r=me > LayoutTests/inspector/unit-tests/url-utilities.html:196 > + // FIXME: <https://webkit.org/b/165155> Web Inspector: Use URL constructor to better handle all kinds of URLs Do we want to leave this stuff in the test case? If it is currently broken in these cases maybe we can rebaseline the results to pass later. (In reply to comment #3) > Comment on attachment 295635 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=295635&action=review > > r=me > > > LayoutTests/inspector/unit-tests/url-utilities.html:196 > > + // FIXME: <https://webkit.org/b/165155> Web Inspector: Use URL constructor to better handle all kinds of URLs > > Do we want to leave this stuff in the test case? If it is currently broken > in these cases maybe we can rebaseline the results to pass later. Leave them in failing at the moment with a FIXME? Yeah, that sounds good. I'll do it. |