Bug 165142

Summary:

REGRESSION (r209058): API test StringBuilderTest.Equal crashing

Product:

WebKit

Reporter:

Ryan Haddad <ryanhaddad>

Component:

New Bugs

Assignee:

Darin Adler <darin>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

ap, commit-queue, darin, sam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=165151

Bug Depends on:

165188

Bug Blocks:

Attachments:

Description	Flags
Crash log	none

Description Ryan Haddad 2016-11-29 08:38:16 PST

Created attachment 295597 [details]
Crash log

API test StringBuilderTest.Equal crashing

https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Release%20WK2%20%28Tests%29/builds/1926

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   TestWTF                       	0x0000000103e34f69 bool WTF::equal<WTF::String>(WTF::StringBuilder const&, WTF::String const&) + 29 (StringBuilder.h:325)
1   TestWTF                       	0x0000000103e326a7 TestWebKitAPI::StringBuilderTest_Equal_Test::TestBody() + 627 (StringBuilder.cpp:226)
2   TestWTF                       	0x0000000103efd128 testing::Test::Run() + 92
3   TestWTF                       	0x0000000103efd8f4 testing::internal::TestInfoImpl::Run() + 178
4   TestWTF                       	0x0000000103efdce8 testing::TestCase::Run() + 188
5   TestWTF                       	0x0000000103f011cd testing::internal::UnitTestImpl::RunAllTests() + 583
6   TestWTF                       	0x0000000103e8804b TestWebKitAPI::TestsController::run(int, char**) + 131 (TestsController.cpp:80)
7   TestWTF                       	0x0000000103ef5309 main + 116 (mainIOS.mm:34)
8   libdyld.dylib                 	0x000000010637168d start + 1

Comment 1 Ryan Haddad 2016-11-29 08:39:36 PST

This seems to have started with http://trac.webkit.org/changeset/209058

Comment 2 Ryan Haddad 2016-11-29 08:49:39 PST

Actually, this isn't limited to ios-simulator, it also appears on macOS debug:

https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/builds/9630

Comment 3 Darin Adler 2016-11-29 08:50:45 PST

I will take a look at this right now.

Comment 4 Darin Adler 2016-11-29 09:18:22 PST

Committed r209074: <http://trac.webkit.org/changeset/209074>

Comment 5 Ryan Haddad 2016-11-29 10:56:38 PST

(In reply to comment #4)
> Committed r209074: <http://trac.webkit.org/changeset/209074>

Thank you for the fix! The test no longer crashes, but now appears to be failing:

FAIL StringBuilderTest.Equal

/Volumes/Data/slave/yosemite-release/build/Tools/TestWebKitAPI/Tests/WTF/StringBuilder.cpp:226
Value of: builder1 == String()
  Actual: false
Expected: true

https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK1%20%28Tests%29/builds/19933/steps/run-api-tests/logs/stdio

Comment 6 WebKit Commit Bot 2016-11-29 20:50:21 PST

Re-opened since this is blocked by bug 165188

Comment 7 Ryan Haddad 2016-11-29 20:56:49 PST

Duping to the original bug for the change that introduced this regression since it was rolled out.

*** This bug has been marked as a duplicate of bug 165003 ***