Bug 165140

Summary: [Win] Skip failing JSC tests.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: Tools / TestsAssignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, lforschler, mark.lam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mark.lam: review+

Per Arne Vollan
Reported 2016-11-29 07:40:16 PST
Some JSC stress tests are failing on Windows.
Attachments
Patch (2.90 KB, patch)
2016-11-29 07:43 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (3.37 KB, patch)
2016-11-30 07:27 PST, Per Arne Vollan 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2016-11-29 07:43:50 PST
Created attachment 295595 [details] Patch
Alex Christensen
Comment 2 2016-11-29 09:52:05 PST
Is there a reason they're failing and cannot be fixed?
Mark Lam
Comment 3 2016-11-29 09:52:54 PST
(In reply to comment #2) > Is there a reason they're failing and cannot be fixed? At minimum, can you add a FIXME with a bug url to fix later / soon?
Per Arne Vollan
Comment 4 2016-11-30 07:26:05 PST
(In reply to comment #3) > (In reply to comment #2) > > Is there a reason they're failing and cannot be fixed? I believe the tests toLocaleString.js and toLocaleStringBasics.js will be fixed when we reenable INTL on Windows. The two other failures should be investigated. > > At minimum, can you add a FIXME with a bug url to fix later / soon? I will update the patch. Thanks for reviewing :)
Per Arne Vollan
Comment 5 2016-11-30 07:27:54 PST
Created attachment 295715 [details] Patch
Mark Lam
Comment 6 2016-11-30 09:20:21 PST
Comment on attachment 295715 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295715&action=review r=me. Please add bug url for re-enabling INTL on Windows. > JSTests/ChakraCore.yaml:78 > + # FIXME: unskip the following test on Windows when INTL is reenabled. You should have a bug url for re-enabling INTL on Windows too. > JSTests/ChakraCore.yaml:975 > + # FIXME: unskip the following test on Windows when INTL is reenabled. Ditto.
Per Arne Vollan
Comment 7 2016-12-01 01:39:38 PST
Committed r209178: <http://trac.webkit.org/changeset/209178>
Note You need to log in before you can comment on or make changes to this bug.