Bug 165127

Summary: Avoid ref-count churn in CSSParser::ValueWithCalculation::setCalculation()
Product: WebKit Reporter: Daniel Bates <dbates>
Component: CSSAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt, koivisto, simon.fraser
Priority: P2    
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Daniel Bates
Reported 2016-11-28 17:21:15 PST
In CSSParser::ValueWithCalculation::setCalculation() we copy the passed RefPtr into CSSParser::ValueWithCalculation::m_calculation. Instead we should WTFMove() it. This has the benefit of avoiding unnecessary ref-count churn.
Attachments
Patch (1.40 KB, patch)
2016-11-28 17:21 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2016-11-28 17:21:46 PST
Created attachment 295555 [details] Patch
Daniel Bates
Comment 2 2016-11-29 10:53:27 PST
Comment on attachment 295555 [details] Patch Clearing flags on attachment: 295555 Committed r209078: <http://trac.webkit.org/changeset/209078>
Daniel Bates
Comment 3 2016-11-29 10:53:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.