Bug 165125

Summary: Avoid ref-count churn in ShadowParseContext::commitColor()
Product: WebKit Reporter: Daniel Bates <dbates>
Component: CSSAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt, koivisto, simon.fraser
Priority: P2    
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews124 for ios-simulator-wk2 none

Description Daniel Bates 2016-11-28 17:15:44 PST 
In ShadowParseContext::commitColor() we copy the committed color (a RefPtr<CSSPrimitiveValue>&&) into ShadowParseContext::color. Instead we should move it. This has the benefit of avoiding unnecessary ref-count churn. Also, ShadowParseContext::commitColor() should take a Ref<CSSPrimitiveValue>&& as it does not expect to be passed a nullptr for the committed color as far as I can tell.
Comment 1 Daniel Bates 2016-11-28 17:16:42 PST 
Created attachment 295554 [details]
Patch
Comment 2 Build Bot 2016-11-28 19:22:50 PST 
Comment on attachment 295554 [details]
Patch

Attachment 295554 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2586178

New failing tests:
intersection-observer/intersection-observer-entry-interface.html
Comment 3 Build Bot 2016-11-28 19:22:55 PST 
Created attachment 295569 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 4 Daniel Bates 2016-11-29 11:03:14 PST 
Comment on attachment 295554 [details]
Patch

Clearing flags on attachment: 295554

Committed r209079: <http://trac.webkit.org/changeset/209079>
Comment 5 Daniel Bates 2016-11-29 11:03:18 PST 
All reviewed patches have been landed.  Closing bug.