| Summary: | Fix exception scope verification failures in ObjectConstructor.cpp and ObjectPrototype.cpp. | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, fpizlo, ggaren, jfbastien, keith_miller, msaboff, saam, ysuzuki | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | WebKit Local Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 162351 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Mark Lam
2016-11-23 13:53:23 PST
Created attachment 295378 [details]
proposed patch.
Comment on attachment 295378 [details] proposed patch. Attachment 295378 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2562237 New failing tests: http/tests/security/cross-frame-access-object-prototype.html Created attachment 295380 [details]
Archive of layout-test-results from ews114 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 295378 [details]
proposed patch.
Taking out of review while I investigate the test failure.
Created attachment 295383 [details]
proposed patch + EWS failure fixed.
Comment on attachment 295383 [details]
proposed patch + EWS failure fixed.
It is invalid to replace returning encodedJSValue() with returning { }. On 32-bit builds, the former is non-zero, while the latter is 0. Will fix this patch.
Created attachment 295423 [details]
proposed patch.
Comment on attachment 295423 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=295423&action=review > Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:137 > + return false; good catch Thanks for the review. Landed in r209020: <http://trac.webkit.org/r209020>. |