|
Description
Darin Adler
2016-11-20 21:21:42 PST
Created attachment 295282 [details]
Patch
Comment on attachment 295282 [details] Patch Attachment 295282 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2550774 Number of test failures exceeded the failure limit. Created attachment 295283 [details]
Archive of layout-test-results from ews102 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 295282 [details] Patch Attachment 295282 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2550776 Number of test failures exceeded the failure limit. Created attachment 295284 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 295282 [details] Patch Attachment 295282 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2550781 Number of test failures exceeded the failure limit. Created attachment 295285 [details]
Archive of layout-test-results from ews115 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 295282 [details] Patch Attachment 295282 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2550779 Number of test failures exceeded the failure limit. Created attachment 295286 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Created attachment 295287 [details]
Patch
Comment on attachment 295287 [details] Patch Attachment 295287 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2551069 Number of test failures exceeded the failure limit. Created attachment 295288 [details]
Archive of layout-test-results from ews117 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 295287 [details] Patch Attachment 295287 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2551087 New failing tests: http/tests/security/contentSecurityPolicy/default-src-inline-blocked.html http/tests/security/contentSecurityPolicy/injected-inline-script-blocked.html fast/dom/nested-script-exceptions.html fast/dom/Document/document-write-recursion.html http/tests/security/contentSecurityPolicy/injected-inline-style-blocked.html http/tests/security/contentSecurityPolicy/inline-script-blocked.html Created attachment 295290 [details]
Archive of layout-test-results from ews103 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 295287 [details] Patch Attachment 295287 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2551086 New failing tests: http/tests/security/contentSecurityPolicy/default-src-inline-blocked.html http/tests/security/contentSecurityPolicy/injected-inline-script-blocked.html fast/dom/nested-script-exceptions.html fast/dom/Document/document-write-recursion.html http/tests/security/contentSecurityPolicy/injected-inline-style-blocked.html http/tests/security/contentSecurityPolicy/inline-script-blocked.html Created attachment 295291 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 295287 [details] Patch Attachment 295287 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2551105 New failing tests: http/tests/security/contentSecurityPolicy/default-src-inline-blocked.html http/tests/security/contentSecurityPolicy/injected-inline-script-blocked.html fast/dom/nested-script-exceptions.html fast/dom/Document/document-write-recursion.html http/tests/security/contentSecurityPolicy/injected-inline-style-blocked.html http/tests/security/contentSecurityPolicy/inline-script-blocked.html Created attachment 295292 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Created attachment 295298 [details]
Patch
Comment on attachment 295298 [details] Patch Attachment 295298 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2552519 New failing tests: fast/forms/style-display-none.html Created attachment 295301 [details]
Archive of layout-test-results from ews114 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 295304 [details]
Patch
OK, I expect this time it will pass all tests. I’m measuring a 3% speedup in Speedometer on my iMac. Created attachment 295313 [details]
Patch
All tests passing. No rush to review this since I’ll be out of town for a few days, but I think it’s ready to go. I hope someone gets a chance to review this soon. I wonder what kind of speedup we will see on ARM. Comment on attachment 295313 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295313&action=review > Source/WebCore/html/track/BufferedLineReader.cpp:95 > + String line = m_lineBuffer.toString(); auto? Committed r209058: <http://trac.webkit.org/changeset/209058> It looks like this is a 33% regression on the json-stringify-tinderbox Kraken test, leading to a 1-1.5% regression on the overall Kraken benchmark. Re-opened since this is blocked by bug 165188 *** Bug 165142 has been marked as a duplicate of this bug. *** *** Bug 165151 has been marked as a duplicate of this bug. *** (In reply to comment #30) > Re-opened since this is blocked by bug 165188 Rolled out this change in https://trac.webkit.org/r209120 due to it breaking an API test. See these bugs for details: https://bugs.webkit.org/show_bug.cgi?id=165142 https://bugs.webkit.org/show_bug.cgi?id=165151 Committed r209129: <http://trac.webkit.org/changeset/209129> (In reply to comment #29) > It looks like this is a 33% regression on the json-stringify-tinderbox > Kraken test, leading to a 1-1.5% regression on the overall Kraken benchmark. Oh, I didn’t see this comment! I will roll out the JSON stringify part of this patch and tackle the slowness in that function another way. I’ll do that right now. (In reply to comment #28) > Committed r209058: <http://trac.webkit.org/changeset/209058> Still running A/B testing but it looks like a ~1% progression on Speedometer. For posterity: stringify bits rolled out in: https://trac.webkit.org/changeset/209173 |