Bug 165001

Summary: Web Automation: add ObjC SPI to set whether a page is controlled by automation
Product: WebKit Reporter: BJ Burg <bburg>
Component: WebKit2Assignee: BJ Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bburg, joepeck, mitz, sam, thorton, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed Fix mitz: review+

Description BJ Burg 2016-11-20 20:03:11 PST
This exists in the WebKit C API. It should be in the ObjC API too. Add it as a private flag on WKWebViewConfiguration and propagate to the existing plumbing in WebPageProxy/WebPageCreationParameters.
Comment 1 BJ Burg 2016-11-20 20:31:40 PST
<rdar://problem/29350432>
Comment 2 BJ Burg 2016-11-21 14:35:04 PST
Created attachment 295312 [details]
Proposed Fix
Comment 3 mitz 2016-11-28 11:19:46 PST
Comment on attachment 295312 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=295312&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:181
> +    _controlledByAutomation = NO;

I know that there are many precedents in this file, but there’s no need to initialize instance variables to 0, NO, nil etc.
Comment 4 BJ Burg 2016-11-29 06:03:31 PST
Committed r209067: <http://trac.webkit.org/changeset/209067>
Comment 5 Radar WebKit Bug Importer 2022-03-01 02:40:08 PST
<rdar://problem/89609900>