Bug 165001

Summary: Web Automation: add ObjC SPI to set whether a page is controlled by automation
Product: WebKit Reporter: Blaze Burg <bburg>
Component: WebKit2Assignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bburg, joepeck, mitz, sam, thorton, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed Fix mitz: review+

Blaze Burg
Reported 2016-11-20 20:03:11 PST
This exists in the WebKit C API. It should be in the ObjC API too. Add it as a private flag on WKWebViewConfiguration and propagate to the existing plumbing in WebPageProxy/WebPageCreationParameters.
Attachments
Proposed Fix (8.61 KB, patch)
2016-11-21 14:35 PST, Blaze Burg 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2016-11-20 20:31:40 PST
<rdar://problem/29350432>
Blaze Burg
Comment 2 2016-11-21 14:35:04 PST
Created attachment 295312 [details] Proposed Fix
mitz
Comment 3 2016-11-28 11:19:46 PST
Comment on attachment 295312 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=295312&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:181 > + _controlledByAutomation = NO; I know that there are many precedents in this file, but there’s no need to initialize instance variables to 0, NO, nil etc.
Blaze Burg
Comment 4 2016-11-29 06:03:31 PST
Committed r209067: <http://trac.webkit.org/changeset/209067>
Radar WebKit Bug Importer
Comment 5 2022-03-01 02:40:08 PST
<rdar://problem/89609900>
Note You need to log in before you can comment on or make changes to this bug.