Bug 164957

Summary:

Update HTML form validation messages

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

DOM

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, buildbot, cdumez, commit-queue, darin, jberlin, jonlee, rmondello, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews101 for mac-yosemite	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Archive of layout-test-results from ews116 for mac-yosemite	none
Patch	none
Archive of layout-test-results from ews103 for mac-yosemite	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none
Archive of layout-test-results from ews115 for mac-yosemite	none
Patch	none

Chris Dumez

Reported 2016-11-18 14:26:03 PST

Update HTML form validation messages as per recent feedback.

Attachments
Patch (25.94 KB, patch) 2016-11-18 16:35 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-yosemite (1.43 MB, application/zip) 2016-11-18 17:35 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (deleted) 2016-11-18 17:43 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-yosemite (1.63 MB, application/zip) 2016-11-18 18:20 PST, Build Bot	no flags	Details
Patch (31.74 KB, patch) 2016-11-18 20:33 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-yosemite (1.08 MB, application/zip) 2016-11-18 21:33 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (10.97 MB, application/zip) 2016-11-18 21:49 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews115 for mac-yosemite (1.68 MB, application/zip) 2016-11-18 22:10 PST, Build Bot	no flags	Details
Patch (34.31 KB, patch) 2016-11-18 23:07 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2016-11-18 14:26:23 PST

<rdar://problem/29338669>

Chris Dumez

Comment 2 2016-11-18 16:35:42 PST

Created attachment 295217 [details] Patch

Build Bot

Comment 3 2016-11-18 17:35:38 PST

Comment on attachment 295217 [details] Patch Attachment 295217 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2539733 New failing tests: fast/forms/validation-message-appearance.html

Build Bot

Comment 4 2016-11-18 17:35:42 PST

Created attachment 295234 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 5 2016-11-18 17:43:45 PST

Comment on attachment 295217 [details] Patch Attachment 295217 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2539714 New failing tests: fast/forms/date/input-date-validation-message.html fast/forms/validation-messages.html

Build Bot

Comment 6 2016-11-18 17:43:49 PST

Created attachment 295236 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 7 2016-11-18 18:20:33 PST

Comment on attachment 295217 [details] Patch Attachment 295217 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2540004 New failing tests: fast/forms/validation-message-appearance.html

Build Bot

Comment 8 2016-11-18 18:20:36 PST

Created attachment 295240 [details] Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5

Chris Dumez

Comment 9 2016-11-18 20:33:31 PST

Created attachment 295247 [details] Patch

Build Bot

Comment 10 2016-11-18 21:33:05 PST

Comment on attachment 295247 [details] Patch Attachment 295247 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2540809 New failing tests: fast/forms/validation-message-appearance.html

Build Bot

Comment 11 2016-11-18 21:33:09 PST

Created attachment 295249 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 12 2016-11-18 21:49:04 PST

Comment on attachment 295247 [details] Patch Attachment 295247 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2540844 New failing tests: fast/forms/date/input-date-validation-message.html

Build Bot

Comment 13 2016-11-18 21:49:08 PST

Created attachment 295250 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 14 2016-11-18 22:10:02 PST

Comment on attachment 295247 [details] Patch Attachment 295247 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2540912 New failing tests: fast/forms/validation-message-appearance.html

Build Bot

Comment 15 2016-11-18 22:10:06 PST

Created attachment 295253 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5

Chris Dumez

Comment 16 2016-11-18 23:07:34 PST

Created attachment 295254 [details] Patch

WebKit Commit Bot

Comment 17 2016-11-19 13:22:22 PST

Comment on attachment 295254 [details] Patch Clearing flags on attachment: 295254 Committed r208930: <http://trac.webkit.org/changeset/208930>

WebKit Commit Bot

Comment 18 2016-11-19 13:22:28 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.