Bug 164954

Summary: Better testing for accessibility media queries
Product: WebKit Reporter: Dean Jackson <dino>
Component: AccessibilityAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
mmaxfield: review+
Patch none

Dean Jackson
Reported 2016-11-18 14:05:53 PST
Add the "force" option for inverted-colors and monochrome.
Attachments
Patch (20.90 KB, patch)
2016-11-18 14:12 PST, Dean Jackson 		mmaxfield: review+
DetailsFormatted DiffDiff
Patch (22.16 KB, patch)
2016-11-18 14:29 PST, Dean Jackson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-11-18 14:06:13 PST
<rdar://problem/29338292>
Dean Jackson
Comment 2 2016-11-18 14:12:44 PST
Created attachment 295188 [details] Patch
Myles C. Maxfield
Comment 3 2016-11-18 14:16:56 PST
Comment on attachment 295188 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295188&action=review > Source/WebCore/css/MediaQueryEvaluator.cpp:264 > + bool isMonochrome = screenIsMonochrome(frame.mainFrame().view()); I suggest putting this inside a conditional below so it doesn't have to be called. > Source/WebCore/css/MediaQueryEvaluator.cpp:280 > + if (frame.settings().forcedColorsAreInvertedAccessibilityValue() == Settings::ForcedAccessibilityValue::On) Ditto. > Source/WebCore/css/MediaQueryEvaluator.cpp:675 > bool userPrefersReducedMotion = platformTheme()->userPrefersReducedMotion(); Ditto. > Source/WebCore/testing/InternalSettings.idl:97 > + attribute ForcedAccessibilityValue forcedColorsAreInvertedAccessibilityValue; > + attribute ForcedAccessibilityValue forcedDisplayIsMonochromeAccessibilityValue; > + attribute ForcedAccessibilityValue forcedPrefersReducedMotionAccessibilityValue; It's pretty awesome you don't need to make SPI for this. It keeps the patch much simpler than it would otherwise be.
Dean Jackson
Comment 4 2016-11-18 14:29:35 PST
Created attachment 295193 [details] Patch
Dean Jackson
Comment 5 2016-11-18 15:00:17 PST
Committed r208899: <http://trac.webkit.org/changeset/208899>
Note You need to log in before you can comment on or make changes to this bug.