Bug 164907

Summary: Add URL::hostAndPort()
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, darin, esprehn+autocc, gyuyoung.kim, jurkuipers
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch achristensen: review+

Carlos Garcia Campos
Reported 2016-11-18 00:31:45 PST
As a convenient way of getting the host and port (if any) as a string. This is already needed in a few places.
Attachments
Patch (4.48 KB, patch)
2016-11-18 00:34 PST, Carlos Garcia Campos 		achristensen: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2016-11-18 00:34:28 PST
Created attachment 295141 [details] Patch
Alex Christensen
Comment 2 2016-11-18 08:32:01 PST
Comment on attachment 295141 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295141&action=review > Source/WebCore/html/URLUtils.h:132 > if (!url.port() || isDefaultPortForProtocol(url.port().value(), url.protocol())) > return url.host(); We can also remove this. The new URLParser will always remove the port if it's the default port for the protocol. Same with the check for hostEnd and pathStart.
Carlos Garcia Campos
Comment 3 2016-11-21 02:04:19 PST
Committed r208945: <http://trac.webkit.org/changeset/208945>
Frances Cornwall
Comment 4 2024-07-01 17:16:58 PDT
*** Bug 17627 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.