Bug 164900

Summary: Web Inspector: Add ability to distinguish if a Script was parsed as a module
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, joepeck, mattbaker, nvasilyev, saam, timothy, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 164830    
Bug Blocks:    
Attachments:
Description Flags
[PATCH] Proposed Fix
timothy: review+, joepeck: commit-queue-
[IMAGE] Module Code with Type Profiler none

Joseph Pecoraro
Reported 2016-11-17 17:21:34 PST
Summary: Add ability to distinguish if a Script was parsed as a module For starters we can use this for Esprima related features: - pretty print module code - enable type profiler and code coverage profilers in module code Where "module code" consists of <script type="module"> and transitively imported modules. Eventually we may want to use this information for other reasons.
Attachments
[PATCH] Proposed Fix (33.65 KB, patch)
2016-11-17 19:26 PST, Joseph Pecoraro 		timothy: review+
joepeck: commit-queue-
DetailsFormatted DiffDiff
[IMAGE] Module Code with Type Profiler (80.25 KB, image/png)
2016-11-17 19:28 PST, Joseph Pecoraro 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-11-17 17:21:49 PST
<rdar://problem/29323817>
Joseph Pecoraro
Comment 2 2016-11-17 19:26:46 PST
Created attachment 295123 [details] [PATCH] Proposed Fix This may not actually depend on the updated Esprima, but it was created from a tree that had it applied so it may not apply otherwise.
Joseph Pecoraro
Comment 3 2016-11-17 19:28:04 PST
Created attachment 295124 [details] [IMAGE] Module Code with Type Profiler
Joseph Pecoraro
Comment 4 2016-12-07 16:05:19 PST
<https://trac.webkit.org/changeset/209492>
Note You need to log in before you can comment on or make changes to this bug.