Summary: | Add _WKIconLoadingDelegate SPI | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||
Component: | WebKit2 | Assignee: | Brady Eidson <beidson> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, barraclough, cdumez, commit-queue, dbates, esprehn+autocc, gyuyoung.kim, japhet, kangil.han, ossy, ryanhaddad | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Brady Eidson
2016-11-17 15:34:55 PST
Manual testing is supported with the changes to MiniBrowser. Automated testing will be covered in https://bugs.webkit.org/show_bug.cgi?id=164895 Created attachment 295096 [details]
Patch
Attachment 295096 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/Cocoa/IconLoadingDelegate.h:58: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/IconLoadingDelegate.mm:74: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/IconLoadingDelegate.mm:89: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/IconLoadingDelegate.mm:89: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:661: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/APIIconLoadingClient.h:42: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/APIIconLoadingClient.h:42: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6658: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 8 in 34 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Rolled out in r209599 due to performance regression. (In reply to comment #7) > Rolled out in r209599 due to performance regression. It broke the Apple Mac build everywhere. It seems you missed to revert Tools/MiniBrowser changes. (In reply to comment #8) > (In reply to comment #7) > > Rolled out in r209599 due to performance regression. > > It broke the Apple Mac build everywhere. I cleaned this up in http://trac.webkit.org/projects/webkit/changeset/209609 Found the one line culprit. Uploading fixed patch for EWS/CQ Created attachment 296719 [details]
Fixed for EWS
Created attachment 296728 [details]
Fixed for EWS/CQ
Attachment 296728 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/Cocoa/IconLoadingDelegate.h:58: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/IconLoadingDelegate.mm:74: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/IconLoadingDelegate.mm:89: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/IconLoadingDelegate.mm:89: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:662: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/APIIconLoadingClient.h:42: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/APIIconLoadingClient.h:42: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6696: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 8 in 32 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 296728 [details] Fixed for EWS/CQ Clearing flags on attachment: 296728 Committed r209640: <http://trac.webkit.org/changeset/209640> All reviewed patches have been landed. Closing bug. |