Bug 164893

Summary: Inlining should be disallowed when JSC_alwaysUseShadowChicken=true.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
saam: review+
proposed patch. saam: review+

Mark Lam
Reported 2016-11-17 15:32:38 PST
The current shadow chicken implementation isn't written to work with inlining.
Attachments
proposed patch. (1.36 KB, patch)
2016-11-17 15:35 PST, Mark Lam 		saam: review+
DetailsFormatted DiffDiff
proposed patch. (1.39 KB, patch)
2016-11-17 15:46 PST, Mark Lam 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2016-11-17 15:33:03 PST
<rdar://problem/29146436>
Mark Lam
Comment 2 2016-11-17 15:35:18 PST
Created attachment 295094 [details] proposed patch.
Saam Barati
Comment 3 2016-11-17 15:37:43 PST
Comment on attachment 295094 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=295094&action=review > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1412 > + if (UNLIKELY(m_hasDebuggerEnabled || Options::alwaysUseShadowChicken())) { Why not set the inlining depth to 1 inside recomputeDependentOptions?
Saam Barati
Comment 4 2016-11-17 15:38:15 PST
Comment on attachment 295094 [details] proposed patch. Also, do you have a test?
Mark Lam
Comment 5 2016-11-17 15:41:40 PST
(In reply to comment #3) > Comment on attachment 295094 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=295094&action=review > > > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1412 > > + if (UNLIKELY(m_hasDebuggerEnabled || Options::alwaysUseShadowChicken())) { > > Why not set the inlining depth to 1 inside recomputeDependentOptions? I like this solution better. I will change the patch. (In reply to comment #4) > Comment on attachment 295094 [details] > proposed patch. > > Also, do you have a test? Sorry, don't have a reduced one.
Mark Lam
Comment 6 2016-11-17 15:46:25 PST
Created attachment 295097 [details] proposed patch.
Mark Lam
Comment 7 2016-11-17 16:24:15 PST
Thanks for the review. Landed in r208866: <http://trac.webkit.org/r208866>.
Note You need to log in before you can comment on or make changes to this bug.