Bug 164855

Summary: [iOS WK2] When zoomed in and panning on pages with fixed bars, parts of the bars are sometimes missing
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 164905    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
sam: review+, buildbot: commit-queue-
Archive of layout-test-results from ews125 for ios-simulator-wk2 none

Simon Fraser (smfr)
Reported 2016-11-16 20:51:00 PST
On a page like http://smfr.org/misc/four-bars-shadows.html, if you zoom in and pan around, bits of the bars are sometimes missing. This happens when they get into tiled mode, but we fail to update the tiles during scrolling. This is related to https://trac.webkit.org/changeset/186155.
Attachments
Patch (72.14 KB, patch)
2016-11-16 21:01 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (72.21 KB, patch)
2016-11-16 21:15 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (74.75 KB, patch)
2016-11-16 22:30 PST, Simon Fraser (smfr) 		sam: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (9.10 MB, application/zip)
2016-11-16 23:49 PST, Build Bot 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2016-11-16 21:01:47 PST
Created attachment 295023 [details] Patch
Radar WebKit Bug Importer
Comment 2 2016-11-16 21:04:14 PST
<rdar://problem/29303891>
Radar WebKit Bug Importer
Comment 3 2016-11-16 21:04:14 PST
<rdar://problem/29303889>
Simon Fraser (smfr)
Comment 4 2016-11-16 21:15:20 PST
Created attachment 295024 [details] Patch
Simon Fraser (smfr)
Comment 5 2016-11-16 22:30:11 PST
Created attachment 295030 [details] Patch
Build Bot
Comment 6 2016-11-16 23:49:02 PST
Comment on attachment 295030 [details] Patch Attachment 295030 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2529833 New failing tests: scrollingcoordinator/ios/sync-layer-positions-after-scroll.html
Build Bot
Comment 7 2016-11-16 23:49:06 PST
Created attachment 295036 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Sam Weinig
Comment 8 2016-11-17 11:02:10 PST
Comment on attachment 295030 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295030&action=review > Source/WebCore/platform/graphics/GraphicsLayer.h:605 > + // If set, overrides m_position. Only used for coverage computation. > + Optional<FloatPoint> m_approximatePosition; This could use a slightly more in depth comment, as the term approximate is a bit scary.
Simon Fraser (smfr)
Comment 9 2016-11-17 21:04:52 PST
Some test infrastructure in bug 164905.
Simon Fraser (smfr)
Comment 10 2016-11-19 11:38:37 PST
https://trac.webkit.org/changeset/208927
Note You need to log in before you can comment on or make changes to this bug.