| Summary: | Wasm function parser should use template functions for each binary and unary opcode | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||
| Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Keith Miller
2016-11-16 14:44:06 PST
Created attachment 294979 [details]
Patch
Attachment 294979 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:767: Bad include order. Mixing system and custom headers. [build/include_order] [4]
ERROR: Source/JavaScriptCore/wasm/WasmFunctionParser.h:211: Non-label code inside switch statements should be indented. [whitespace/indent] [4]
Total errors found: 2 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 294979 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294979&action=review LGTM > Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:169 > + Why the blank line here but not below at line 171-172? Comment on attachment 294979 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294979&action=review >> Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:169 >> + > > Why the blank line here but not below at line 171-172? It felt weird to have a blank have the templates on top of each other. I don't feel strongly about it. So, I can change it if you want. Committed r208821: <http://trac.webkit.org/changeset/208821> |