Summary: | Remove async/await compile time flag and enable tests | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||
Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, caitp, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, oliver, ticaiolima, webkit-bug-importer, ysuzuki | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Saam Barati
2016-11-16 11:51:53 PST
Created attachment 295031 [details]
patch
Attachment 295031 [details] did not pass style-queue:
ERROR: Source/WebCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). [featuredefines/equality] [5]
ERROR: Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). [featuredefines/equality] [5]
ERROR: Source/WebCore/ChangeLog:9: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
ERROR: Source/WebKit/mac/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). [featuredefines/equality] [5]
ERROR: Source/JavaScriptCore/parser/Parser.cpp:3233: One line control clauses should not use braces. [whitespace/braces] [4]
ERROR: Source/WebKit2/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). [featuredefines/equality] [5]
Total errors found: 6 in 14 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 295031 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=295031&action=review r=me > JSTests/test262.yaml:66449 > + cmd: runTest262 :fail, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict] What happens? Comment on attachment 295031 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=295031&action=review >> JSTests/test262.yaml:66449 >> + cmd: runTest262 :fail, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict] > > What happens? Not sure, I'll file a bug. Comment on attachment 295031 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=295031&action=review >>> JSTests/test262.yaml:66449 >>> + cmd: runTest262 :fail, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict] >> >> What happens? > > Not sure, I'll file a bug. https://bugs.webkit.org/show_bug.cgi?id=161408 it's been filed for a while (In reply to comment #6) > Comment on attachment 295031 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=295031&action=review > > >>> JSTests/test262.yaml:66449 > >>> + cmd: runTest262 :fail, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict] > >> > >> What happens? > > > > Not sure, I'll file a bug. > > https://bugs.webkit.org/show_bug.cgi?id=161408 it's been filed for a while Interesting. On ToT: ``` var f = (a, a) => 1; ``` throws a syntax error. But: ``` var O = { m(a, a) { return 1; } }; ``` does not. Comment on attachment 295031 [details] patch Rejecting attachment 295031 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 295031, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/2530150 Created attachment 295039 [details]
patch for landing
Comment on attachment 295039 [details] patch for landing Clearing flags on attachment: 295039 Committed r208843: <http://trac.webkit.org/changeset/208843> All reviewed patches have been landed. Closing bug. |