Bug 164751 – Fix iOS API test assertion after r208534

• Component: New Bugs
• Status: RESOLVED FIXED

[Alex Christensen]

Fix iOS API test assertion after r208534

[Alex Christensen]

Created attachment 294780 [details]
Patch

[Build Bot]

Comment on attachment 294780 [details]
Patch

Attachment 294780 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2516950

New failing tests:
js/regress-141098.html

[Build Bot]

Created attachment 294791 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Alex Christensen]

Test failures seem unrelated.  Will double check before landing.  Please review.

[Alex Christensen]

Created attachment 294807 [details]
Patch

[Geoffrey Garen]

Comment on attachment 294807 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294807&action=review

> Source/WebKit/mac/WebView/WebView.mm:1426
> +    WebInstallMemoryPressureHandler();

I think this means that we'll stop calling WebCore::releaseMemory on iOS, and I think that might cause a memory use regression.

It seems strange that we register both MemoryPressureHandler::m_lowMemoryHandler and MemoryPressureHandler::m_releaseMemoryBlock on iOS. You should file a bug about that for Andreas.

I think the best way to fix the assertion is to delete it, since we have been violating it for a while.

[Alex Christensen]

Created attachment 294851 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 294851 [details]
Patch

Clearing flags on attachment: 294851

Committed r208772: <http://trac.webkit.org/changeset/208772>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

*** Bug 164593 has been marked as a duplicate of this bug. ***