Bug 164743

Summary: Add Wasm select
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jfbastien, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Keith Miller
Reported 2016-11-14 15:56:32 PST
Add Wasm select
Attachments
Patch (7.61 KB, patch)
2016-11-14 16:14 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (7.55 KB, patch)
2016-11-14 16:19 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-11-14 16:14:25 PST
Created attachment 294771 [details] Patch
Keith Miller
Comment 2 2016-11-14 16:19:09 PST
Created attachment 294773 [details] Patch
JF Bastien
Comment 3 2016-11-14 16:28:47 PST
Comment on attachment 294773 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294773&action=review > Source/JavaScriptCore/wasm/WasmFunctionParser.h:202 > + if (!popExpressionStack(condition)) This is last: select: a ternary operator with two operands, which have the same type as each other, plus a boolean (i32) condition. select returns the first operand if the condition operand is non-zero, or the second otherwise. I think the values are inverted as well.
JF Bastien
Comment 5 2016-11-14 16:49:08 PST
(In reply to comment #4) > Changed here: https://github.com/WebAssembly/design/pull/489 > Spec: > https://github.com/WebAssembly/spec/commit/ > 43c87e32262d00aad59d771711b32145396fb0b1 Ignore me, I can't do stack growth directions.
Keith Miller
Comment 6 2016-11-14 16:49:31 PST
(In reply to comment #3) > Comment on attachment 294773 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=294773&action=review > > > Source/JavaScriptCore/wasm/WasmFunctionParser.h:202 > > + if (!popExpressionStack(condition)) > > This is last: > > select: a ternary operator with two operands, which have the same type as > each other, plus a boolean (i32) condition. select returns the first operand > if the condition operand is non-zero, or the second otherwise. > > I think the values are inverted as well. I think it's right the condition is the last thing pushed to the stack and so it's the first thing popped off the stack in select.
WebKit Commit Bot
Comment 7 2016-11-14 17:13:54 PST
Comment on attachment 294773 [details] Patch Clearing flags on attachment: 294773 Committed r208719: <http://trac.webkit.org/changeset/208719>
WebKit Commit Bot
Comment 8 2016-11-14 17:13:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.