Bug 164653
| Summary: | We should make the contract of holding a lock while modifying a ByValInfo explicit in ByValInfo's API | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | benjamin, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, oliver, ticaiolima, ysuzuki |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Saam Barati
Currently, we just load/store to raw members of the class. We should make it have some public API that take ConcurrentJITLocker as a parameter.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Yusuke Suzuki
I think it is fine adding the same thing to StructureStubInfo.
It seems that StructureStubInfo->tookSlowPath is also accessed from DFG, but writing it in baseline does not hold any locks.