Bug 164646 – RenderFlowThread's containing block cache should be invalidated before calling styleDidChange.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan]

So that ::styleDidChange can safely use RenderBlock::locateFlowThreadContainingBlock() with the new containing block context.

[alan]

Created attachment 294515 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 294515 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294515&action=review

> Source/WebCore/ChangeLog:12
> +        Relying on existing tests.

Maybe say "no known behavior change"

> Source/WebCore/rendering/RenderElement.cpp:414
> +    // Make sure we invalidate the containing block cache for flows when the contianing block context changes
> +    // so that styleDidChange can safely use RenderBlock::locateFlowThreadContainingBlock()
> +    if (is<RenderBlock>(*this) && oldStyle.position() != m_style.position())
> +        downcast<RenderBlock>(*this).resetFlowThreadContainingBlockAndChildInfoIncludingDescendants();

I would prefer blank lines before and after to visually separate this "weird" code from the rest.

[alan]

Created attachment 294520 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 294520 [details]
Patch

Clearing flags on attachment: 294520

Committed r208605: <http://trac.webkit.org/changeset/208605>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.