Bug 164643

Summary: [MediaStream] defer resolution of getUserMedia promise made in a background tab
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, jer.noble, ryanhaddad, thiago.lacerda, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch. none

Description Eric Carlson 2016-11-11 10:56:36 PST
Don't prompt the user for device access or start media streams when a tab is in the background.
Comment 1 Eric Carlson 2016-11-11 10:57:23 PST
<rdar://problem/29048317>
Comment 2 Eric Carlson 2016-11-11 12:39:50 PST
Created attachment 294519 [details]
Proposed patch.
Comment 3 Brady Eidson 2016-11-11 13:11:50 PST
Comment on attachment 294519 [details]
Proposed patch.

I'm not sure if this is the right way to do whatever it is you're doing, but the code seems fine. :)
Comment 4 WebKit Commit Bot 2016-11-11 13:48:28 PST
Comment on attachment 294519 [details]
Proposed patch.

Clearing flags on attachment: 294519

Committed r208606: <http://trac.webkit.org/changeset/208606>
Comment 5 WebKit Commit Bot 2016-11-11 13:48:32 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Ryan Haddad 2016-11-11 14:16:35 PST
(In reply to comment #4)
> Comment on attachment 294519 [details]
> Proposed patch.
> 
> Clearing flags on attachment: 294519
> 
> Committed r208606: <http://trac.webkit.org/changeset/208606>

This change appears to have broken the Windows build:

https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/81884
Comment 7 Eric Carlson 2016-11-11 14:57:00 PST
Plus r208612 to fix the Windows build.