Bug 164642

Summary: Allow mutable lambdas in HashMap::ensure
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Alex Christensen
Reported 2016-11-11 10:35:15 PST
Allow mutable lambdas in HashMap::ensure
Attachments
Patch (6.02 KB, patch)
2016-11-11 10:35 PST, Alex Christensen 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-11-11 10:35:59 PST
Created attachment 294505 [details] Patch
Alex Christensen
Comment 2 2016-11-11 11:14:48 PST
http://trac.webkit.org/changeset/208600
Filip Pizlo
Comment 3 2016-11-12 10:11:06 PST
Comment on attachment 294505 [details] Patch Neat! I didn't know about mutable lambdas until this patch made me look them up. Do we have a plan for how far to push rvalue reference lambdas? Is the idea that all const lambda references would go away, or something else?
Alex Christensen
Comment 4 2016-11-14 12:19:49 PST
It's probable that we'll need to change more const lambda references to universal references. Trying to find them all would be good, but any such attempt would probably miss some.
Saam Barati
Comment 5 2016-11-16 12:32:04 PST
Interesting, I also didn't know mutable lambdas were a thing. I've definitely written code that should've just been a mutable lambda but instead I had copying code in the body of the lambda.
Note You need to log in before you can comment on or make changes to this bug.