Bug 164610

Summary: Get touch bar code building for open source builds
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, benjamin, cdumez, cmarcelo, commit-queue, dbates, mitz, sam, thorton, wenson_hsieh
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
wenson_hsieh: review+
Patch wenson_hsieh: review+

Description Beth Dakin 2016-11-10 13:03:16 PST 
Get touch bar code building for open source builds
Comment 1 Beth Dakin 2016-11-10 13:07:49 PST 
Created attachment 294400 [details]
Patch
Comment 2 WebKit Commit Bot 2016-11-10 13:09:42 PST 
Attachment 294400 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/Platform.h:1217:  CPP comments are not allowed in Platform.h, please use C comments /* ... */  [build/cpp_comment] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 mitz 2016-11-10 13:18:10 PST 
Comment on attachment 294400 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294400&action=review

> Source/WTF/wtf/Platform.h:1214
> +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED >= 101201

I don’t think this is quite right. When building with the 10.12.1 SDK but targeting earlier-than-10.12 deployment, the code for these capabilities should not be compiled. So you should also check that __MAC_OS_X_VERSION_MIN_REQUIRED is at least 101200.
Comment 4 Beth Dakin 2016-11-10 13:35:13 PST 
Created attachment 294406 [details]
Patch

Thanks Wenson! Here is a new patch that addresses Dan's comment.
Comment 5 Beth Dakin 2016-11-11 10:57:40 PST 
Thank you! https://trac.webkit.org/changeset/208595