Bug 164580 – CSS 3D transform by matrix3d with translations doesn't take page zoom into account

• Component: CSS
• Status: RESOLVED FIXED

[Franklin Ta]

Chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=242685.

Fixed in https://codereview.chromium.org/2482753002

Analogous change is in https://github.com/WebKit/webkit/blob/48bf6ce187a5b7a28b8ab4e3f3e45866487b5b17/Source/WebCore/css/TransformFunctions.cpp#L292 where it should be:

            TransformationMatrix matrix(downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(0)).doubleValue(),
                downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(1)).doubleValue(),
                downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(2)).doubleValue(),
                downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(3)).doubleValue() / conversionData.zoom(),
                downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(4)).doubleValue(),
                downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(5)).doubleValue(),
                downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(6)).doubleValue(),
                downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(7)).doubleValue() / conversionData.zoom(),
                downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(8)).doubleValue(),
                downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(9)).doubleValue(),
                downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(10)).doubleValue(),
                downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(11)).doubleValue() / conversionData.zoom(),
                conversionData.zoom() * downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(12)).doubleValue(),
                conversionData.zoom() * downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(13)).doubleValue(),
                conversionData.zoom() * downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(14)).doubleValue(),
                downcast<CSSPrimitiveValue>(*transformValue.itemWithoutBoundsCheck(15)).doubleValue());

Or have that logic encapsulated in a zoom method on TransformationMatrix.

[Radar WebKit Bug Importer]

<rdar://problem/29232128>

[Fujii Hironori]

*** Bug 246198 has been marked as a duplicate of this bug. ***

[Fujii Hironori]

Thank you very much, Franklin! I'm going to cherry-pick your chromium patch.

[Simon Fraser (smfr)]

How does this relate to bug 245606 ?

[Fujii Hironori]

Oh, I didn't know that. It's an incomplete fix. See comment#0. 3rd, 7th, 11th elements needs divisions.

[Fujii Hironori]

Created attachment 462919 [details]
Patch

[Fujii Hironori]

Pull request: https://github.com/WebKit/WebKit/pull/5220

[EWS]

Committed 255416@main (fee4b197a6bb): <https://commits.webkit.org/255416@main>

Reviewed commits have been landed. Closing PR #5220 and removing active labels.