Bug 164560

Summary:

MediaStreamTrack should use more Ref<> and less RefPtr<>

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore Misc.

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alex, commit-queue, eric.carlson, jer.noble, pnormand

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

youenn fablet

Reported 2016-11-09 13:51:47 PST

Some refactoring might help

Attachments
Patch (24.32 KB, patch) 2016-11-09 13:56 PST, youenn fablet	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2016-11-09 13:56:09 PST

Created attachment 294283 [details] Patch

WebKit Commit Bot

Comment 2 2016-11-10 09:29:27 PST

Comment on attachment 294283 [details] Patch Clearing flags on attachment: 294283 Committed r208542: <http://trac.webkit.org/changeset/208542>

WebKit Commit Bot

Comment 3 2016-11-10 09:29:30 PST

All reviewed patches have been landed. Closing bug.

Darin Adler

Comment 4 2016-11-10 12:24:09 PST

Comment on attachment 294283 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294283&action=review > Source/WebCore/platform/mediastream/MediaStreamPrivate.cpp:55 > + ASSERT(source); > + tracks.append(MediaStreamTrackPrivate::create(source.releaseNonNull())); This is an anti-pattern. The releaseNonNull function includes this assertion and we generally don’t want to a second redundant assertion before each time we use that function. > Source/WebCore/platform/mediastream/MediaStreamPrivate.cpp:60 > + ASSERT(source); > + tracks.append(MediaStreamTrackPrivate::create(source.releaseNonNull())); Ditto.

Note You need to log in before you can comment on or make changes to this bug.