Bug 164558 – Block synchronous loads for resources that use HTTP 0.9 protocol

• Component: WebCore Misc.
• Status: RESOLVED INVALID

[Daniel Bates]

We should block synchronous loads for resources that use the HTTP 0.9 protocol.

[Daniel Bates]

Created attachment 294268 [details]
Patch and layout tests

[Build Bot]

Comment on attachment 294268 [details]
Patch and layout tests

Attachment 294268 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2485095

New failing tests:
http/tests/security/http-0.9/xhr-blocked.html

[Build Bot]

Created attachment 294281 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 294268 [details]
Patch and layout tests

Attachment 294268 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2485120

New failing tests:
http/tests/security/http-0.9/xhr-blocked.html

[Build Bot]

Created attachment 294282 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 294268 [details]
Patch and layout tests

Attachment 294268 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2485130

New failing tests:
http/tests/security/http-0.9/xhr-blocked.html

[Build Bot]

Created attachment 294285 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Daniel Bates]

Created attachment 294288 [details]
Patch and layout test

[Brent Fulgham]

Comment on attachment 294288 [details]
Patch and layout test

Looks good. r=me.

[Brady Eidson]

This patch seems wrong.

It waits for the sync response to come back from the loading process, which means that the load actually took place.

i.e., it could be a 10mb file that takes ~60 seconds to load, and we'd load it, and block the web process for a minute, then throw it all away.

Instead, why can't we decide that it's http 0.9 *right at response time* and kill the load then?

[Daniel Bates]

(In reply to comment #10)
> This patch seems wrong.
> 
> It waits for the sync response to come back from the loading process, which
> means that the load actually took place.
> 

You're right!

> i.e., it could be a 10mb file that takes ~60 seconds to load, and we'd load
> it, and block the web process for a minute, then throw it all away.
> 
> Instead, why can't we decide that it's http 0.9 *right at response time* and
> kill the load then?

Will update patch to do this.

[Daniel Bates]

Comment on attachment 294288 [details]
Patch and layout test

This patch is not necessary. We need to move the HTTP 0.9 blocking machinery to ResourceHandle/NetworkLoad to ensure that the machinery applies to all loads.