Bug 164476 – Fix the !ENABLE(VIDEO_TRACK) build

• Component: New Bugs
• Status: RESOLVED FIXED

[Csaba Osztrogonác]

CSSSelector::PseudoElementCue is defined inside ENABLE(VIDEO_TRACK),
but it is used unconditionally. It should be fixed.

[Csaba Osztrogonác]

Created attachment 294055 [details]
Patch

[Darin Adler]

Comment on attachment 294055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294055&action=review

> Source/WebCore/css/parser/CSSParserValues.h:275
> -    bool needsImplicitShadowCombinatorForMatching() const { return match() == CSSSelector::PseudoElement && (pseudoElementType() == CSSSelector::PseudoElementWebKitCustom || pseudoElementType() == CSSSelector::PseudoElementUserAgentCustom || pseudoElementType() == CSSSelector::PseudoElementWebKitCustomLegacyPrefixed || pseudoElementType() == CSSSelector::PseudoElementCue); }
> +    bool needsImplicitShadowCombinatorForMatching() const
> +    {
> +        return match() == CSSSelector::PseudoElement
> +            && (pseudoElementType() == CSSSelector::PseudoElementWebKitCustom
> +                || pseudoElementType() == CSSSelector::PseudoElementUserAgentCustom
> +#if ENABLE(VIDEO_TRACK)
> +                || pseudoElementType() == CSSSelector::PseudoElementCue
> +#endif
> +                || pseudoElementType() == CSSSelector::PseudoElementWebKitCustomLegacyPrefixed);
> +    }

When member function bodies get big like this, I like to move them out of class definitions into separate function definitions, like CSSParserValue::setFromValueList below.

[Csaba Osztrogonác]

Created attachment 294698 [details]
patch for landing

[Csaba Osztrogonác]

Created attachment 294700 [details]
patch for landing

[WebKit Commit Bot]

Comment on attachment 294700 [details]
patch for landing

Clearing flags on attachment: 294700

Committed r208681: <http://trac.webkit.org/changeset/208681>