Summary: | Fix the !ENABLE(VIDEO_TRACK) build | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||||||
Component: | New Bugs | Assignee: | Csaba Osztrogonác <ossy> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, ossy | ||||||||
Priority: | P2 | ||||||||||
Version: | Other | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Csaba Osztrogonác
2016-11-07 05:11:24 PST
Created attachment 294055 [details]
Patch
Comment on attachment 294055 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294055&action=review > Source/WebCore/css/parser/CSSParserValues.h:275 > - bool needsImplicitShadowCombinatorForMatching() const { return match() == CSSSelector::PseudoElement && (pseudoElementType() == CSSSelector::PseudoElementWebKitCustom || pseudoElementType() == CSSSelector::PseudoElementUserAgentCustom || pseudoElementType() == CSSSelector::PseudoElementWebKitCustomLegacyPrefixed || pseudoElementType() == CSSSelector::PseudoElementCue); } > + bool needsImplicitShadowCombinatorForMatching() const > + { > + return match() == CSSSelector::PseudoElement > + && (pseudoElementType() == CSSSelector::PseudoElementWebKitCustom > + || pseudoElementType() == CSSSelector::PseudoElementUserAgentCustom > +#if ENABLE(VIDEO_TRACK) > + || pseudoElementType() == CSSSelector::PseudoElementCue > +#endif > + || pseudoElementType() == CSSSelector::PseudoElementWebKitCustomLegacyPrefixed); > + } When member function bodies get big like this, I like to move them out of class definitions into separate function definitions, like CSSParserValue::setFromValueList below. Created attachment 294698 [details]
patch for landing
Created attachment 294700 [details]
patch for landing
Comment on attachment 294700 [details] patch for landing Clearing flags on attachment: 294700 Committed r208681: <http://trac.webkit.org/changeset/208681> |