Bug 164474

Summary: Fix Tools build on case sensitive file systems
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, ossy
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Csaba Osztrogonác
Reported 2016-11-07 04:19:27 PST
Apple Mac cmake build is broken: CMake Error at Tools/DumpRenderTree/CMakeLists.txt:141 (add_library): Cannot find source file: TestNetscapePlugin/PluginObject.cpp Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp .hxx .in .txx --- The problem is that the directory name is not TestNetscapePlug_i_n, but TestNetscapePlug_I_n. Let's fix the cmake build system.
Attachments
Patch (11.83 KB, patch)
2016-11-07 04:22 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (12.46 KB, patch)
2016-11-07 04:31 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (12.45 KB, patch)
2016-11-07 04:32 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2016-11-07 04:22:53 PST
Created attachment 294051 [details] Patch patch for EWS, because it might affect the Apple Win build too.
WebKit Commit Bot
Comment 2 2016-11-07 04:29:29 PST
Attachment 294051 [details] did not pass style-queue: ERROR: Tools/DumpRenderTree/PlatformWin.cmake:38: Alphabetical sorting problem. "TestNetscapePlugIn/Tests/win/CallJSThatDestroysPlugin.cpp" should be before "win/TestNetscapePlugin.rc". [list/order] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Csaba Osztrogonác
Comment 3 2016-11-07 04:29:45 PST
CMake Error at Tools/MiniBrowser/mac/CMakeLists.txt:41 (add_executable): Cannot find source file: /Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/MiniBrowser/MiniBrowserWebProcessPlugin.m Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp .hxx .in .txx -- not MiniBrowserWebProcessPlug_i_n.h, but MiniBrowserWebProcessPlug_I_n.h
Csaba Osztrogonác
Comment 4 2016-11-07 04:31:25 PST
Created attachment 294052 [details] Patch
Csaba Osztrogonác
Comment 5 2016-11-07 04:32:35 PST
Created attachment 294053 [details] Patch
WebKit Commit Bot
Comment 6 2016-11-07 04:34:17 PST
Attachment 294053 [details] did not pass style-queue: ERROR: Tools/DumpRenderTree/PlatformWin.cmake:38: Alphabetical sorting problem. "TestNetscapePlugIn/Tests/win/CallJSThatDestroysPlugin.cpp" should be before "win/TestNetscapePlugin.rc". [list/order] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Csaba Osztrogonác
Comment 7 2016-11-09 08:55:17 PST
Comment on attachment 294053 [details] Patch Clearing flags on attachment: 294053 Committed r208429: <http://trac.webkit.org/changeset/208429>
Csaba Osztrogonác
Comment 8 2016-11-09 08:55:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.