Bug 16446

Summary: Edits to expand on Windows debug environment
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit WebsiteAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mrowe
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch to expand debugging instructions for Windows.
none
screenshot for website changes
none
Screenshot for setting "/console" flag in VS2005
none
Website update including new VS 2005 screenshots. mjs: review+

Description Brent Fulgham 2007-12-14 22:52:34 PST
The instructions for debugging under Windows omit some useful details.  This patch adds a couple of screenshots and some explanatory text.
Comment 1 Brent Fulgham 2007-12-14 22:53:47 PST
Created attachment 17903 [details]
Patch to expand debugging instructions for Windows.
Comment 2 Brent Fulgham 2007-12-14 22:54:28 PST
Created attachment 17904 [details]
screenshot for website changes
Comment 3 Brent Fulgham 2007-12-14 22:55:08 PST
Created attachment 17905 [details]
Screenshot for setting "/console" flag in VS2005
Comment 4 Mark Rowe (bdash) 2007-12-14 23:16:07 PST
Brent, can you "svn add" the images and use "svn-create-patch" to create the patch?  That will include the screenshots in the patch and make it a little easier to land.
Comment 5 Adam Roben (:aroben) 2007-12-15 09:37:45 PST
Comment on attachment 17903 [details]
Patch to expand debugging instructions for Windows.

These instructions look great!

+<li><p>If you want to see the helpful output debug messages, you should edit the debug settings for the Safari solution (i.e., the pseudo-project created when the debugger attached to Safari):</p>
+<img src="debug_vs2005.jpg">
+<p>You should consider including the command-line switch '<span class="code">/console</span>'.  This causes Safari to run with an open DOS shell in which output messages (created with the <span class="code">LOG</span> macro).</p>
+<img src="console_vs2005.jpg"></li>

I wonder if we should just make debug-safari do this by default? It would require changing FindSafari.
Comment 6 Brent Fulgham 2007-12-16 14:35:46 PST
Created attachment 17940 [details]
Website update including new VS 2005 screenshots.

Updated per comments in this bug report.
Comment 7 Brent Fulgham 2007-12-16 14:36:07 PST
Comment on attachment 17940 [details]
Website update including new VS 2005 screenshots.

Updated per notes on bug.
Comment 8 Maciej Stachowiak 2007-12-16 14:36:49 PST
Comment on attachment 17940 [details]
Website update including new VS 2005 screenshots.

r=me
Comment 9 Mark Rowe (bdash) 2007-12-16 17:21:17 PST
Landed in r28783.