Bug 164448 – [MinGW] Fixed C99/C++11 format attributes in printf-like functions

• Component: Web Template Framework
• Status: RESOLVED FIXED

[Konstantin Tokarev]

By default MinGW uses printf-like function provided in msvcrt.dll, however they miss support for C99/C++11 format attributes. Use MinGW implementations instead.

[Konstantin Tokarev]

Created attachment 293993 [details]
Patch

[Michael Catanzaro]

Comment on attachment 293993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293993&action=review

> Source/WTF/wtf/Assertions.h:55
> +#if COMPILER(MINGW)
> +/* For __MINGW_PRINTF_FORMAT */
> +#include <stdio.h>
> +#endif

stdio.h exists everywhere, so I think this isn't worth the preprocessor guards.

[Konstantin Tokarev]

I was unsure if it gets included everywhere

[Michael Catanzaro]

It probably does and it will probably slow things down very slightly, but honestly, I'd rather have fewer platform-specific #include differences. Anyone actually using mingw to develop is going to break the build by forgetting to include stdio.h now!

But you know, maybe a better solution would be to eschew the header and just open-code the value of __MINGW_PRINTF_FORMAT instead.

[Konstantin Tokarev]

__MINGW_PRINTF_FORMAT is defined as gnu_printf. I was following recommended usage of __USE_MINGW_ANSI_STDIO, however it seems that gnu_printf is not MinGW-specific so it should be safe to use it without macro

[Konstantin Tokarev]

Committed r208418: <http://trac.webkit.org/changeset/208418>