Bug 164429

Summary:

Add support for Wasm br_table

Product:

WebKit

Reporter:

Keith Miller <keith_miller>

Component:

New Bugs

Assignee:

Keith Miller <keith_miller>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, mark.lam, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	msaboff: review+

Keith Miller

Reported 2016-11-04 13:44:23 PDT

Add support for Wasm br_table

Attachments
Patch (16.26 KB, patch) 2016-11-04 13:45 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Patch (19.71 KB, patch) 2016-11-04 14:56 PDT, Keith Miller	msaboff: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Keith Miller

Comment 1 2016-11-04 13:45:23 PDT

Created attachment 293922 [details] Patch

Keith Miller

Comment 2 2016-11-04 13:46:39 PDT

Comment on attachment 293922 [details] Patch not ready for review.

Keith Miller

Comment 3 2016-11-04 14:56:10 PDT

Created attachment 293937 [details] Patch

JF Bastien

Comment 4 2016-11-04 15:14:14 PDT

Comment on attachment 293937 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293937&action=review Looks good besides typo. > Source/JavaScriptCore/wasm/WasmValidate.cpp:269 > + m_errorMessage = makeString("Attempting to add a br_table with different expected types. Default target has type: ", toString(defaultTarget.signature()), " but case hase type: ", toString(target->signature())); typo "hase"

Keith Miller

Comment 5 2016-11-04 15:15:11 PDT

Comment on attachment 293937 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293937&action=review >> Source/JavaScriptCore/wasm/WasmValidate.cpp:269 >> + m_errorMessage = makeString("Attempting to add a br_table with different expected types. Default target has type: ", toString(defaultTarget.signature()), " but case hase type: ", toString(target->signature())); > > typo "hase" Fixed.

Michael Saboff

Comment 6 2016-11-04 15:15:35 PDT

Comment on attachment 293937 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293937&action=review > Source/JavaScriptCore/ChangeLog:8 > + This patch adds support for Wasm br_table. the Wasm br_table Nit - capitalize "the".

Keith Miller

Comment 7 2016-11-04 15:17:05 PDT

Comment on attachment 293937 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293937&action=review >> Source/JavaScriptCore/ChangeLog:8 >> + This patch adds support for Wasm br_table. the Wasm br_table > > Nit - capitalize "the". Fixed.

Michael Saboff

Comment 8 2016-11-04 15:33:02 PDT

Comment on attachment 293937 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293937&action=review r=me > Source/JavaScriptCore/wasm/WasmFunctionParser.h:416 > + Nit - two blank lines.

Keith Miller

Comment 9 2016-11-04 15:56:23 PDT

Committed r208402: <http://trac.webkit.org/changeset/208402>

Note You need to log in before you can comment on or make changes to this bug.