Bug 16438

Summary:

another round of PCRE clean-up

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

JavaScriptCore

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Enhancement

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
patch (all regression tests pass)	none
patch (all regression tests pass)	none
patch with "ignore whitespace differences" on -- may be easier to review	none
patch rebased to r28788	mjs: review+

Darin Adler

Reported 2007-12-14 10:45:59 PST

While looking into a regression, which I'll fix soon, I did another round of PCRE code tweaks.

Attachments
patch (all regression tests pass) (168.46 KB, patch) 2007-12-14 11:08 PST, Darin Adler	no flags	Details Formatted Diff Diff
patch (all regression tests pass) (168.20 KB, patch) 2007-12-15 20:01 PST, Darin Adler	no flags	Details Formatted Diff Diff
patch with "ignore whitespace differences" on -- may be easier to review (158.42 KB, patch) 2007-12-15 20:02 PST, Darin Adler	no flags	Details Formatted Diff Diff
patch rebased to r28788 (168.27 KB, patch) 2007-12-16 17:36 PST, Darin Adler	mjs: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2007-12-14 11:08:11 PST

Created attachment 17896 [details] patch (all regression tests pass)

Darin Adler

Comment 2 2007-12-15 20:01:45 PST

Created attachment 17921 [details] patch (all regression tests pass) Earlier patch had an extra ChangeLog entry.

Darin Adler

Comment 3 2007-12-15 20:02:11 PST

Created attachment 17922 [details] patch with "ignore whitespace differences" on -- may be easier to review

Darin Adler

Comment 4 2007-12-16 17:36:06 PST

Maciej Stachowiak

Comment 5 2007-12-16 18:04:38 PST

Comment on attachment 17947 [details] patch rebased to r28788 r=me

Darin Adler

Comment 6 2007-12-16 20:20:38 PST

Committed revision 28793.

Note You need to log in before you can comment on or make changes to this bug.