Bug 164358

Summary: Purge PassRefPtr from Tools
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, jh718.park, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2016-11-02 23:12:31 PDT
Purge PassRefPtr from Tools
Attachments
Patch (130.96 KB, patch)
2016-11-02 23:14 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (137.70 KB, patch)
2016-11-03 10:48 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Patch (137.55 KB, patch)
2016-11-03 11:01 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-11-02 23:14:37 PDT
Created attachment 293749 [details] Patch
WebKit Commit Bot
Comment 2 2016-11-02 23:18:13 PDT
Attachment 293749 [details] did not pass style-queue: ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:77: 'childAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:91: 'linkedUIElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:185: 'selectedRowAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:187: 'disclosedRowAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:188: 'rowAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:191: 'ariaOwnsElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:192: 'ariaFlowToElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:193: 'ariaControlsElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:249: 'textMarkerForIndex' is incorrectly named. It should be named 'protector' or 'protectedInt'. [readability/naming/protected] [4] Total errors found: 9 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 3 2016-11-02 23:29:26 PDT
Could somebody working on linux get this building? Also check the !HAVE(ACCESSIBILITY) build.
WebKit Commit Bot
Comment 4 2016-11-03 01:17:54 PDT
Attachment 293749 [details] did not pass style-queue: ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:77: 'childAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:91: 'linkedUIElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:185: 'selectedRowAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:187: 'disclosedRowAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:188: 'rowAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:191: 'ariaOwnsElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:192: 'ariaFlowToElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:193: 'ariaControlsElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:249: 'textMarkerForIndex' is incorrectly named. It should be named 'protector' or 'protectedInt'. [readability/naming/protected] [4] Total errors found: 9 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Michael Catanzaro
Comment 5 2016-11-03 09:53:17 PDT
(In reply to comment #3) > Could somebody working on linux get this building? Yeah I have some time later today. > Also check the !HAVE(ACCESSIBILITY) build. WebKitGTK+ doesn't support !HAVE(ACCESSIBILITY).
Alex Christensen
Comment 6 2016-11-03 10:46:03 PDT
If we break the !HAVE(ACCESSIBILITY) build, then somebody who maintains that configuration of EFL will have to fix it. Or we could remove the !HAVE(ACCESSIBILITY) completely, but we would need some input from EFL maintainers to do that.
Michael Catanzaro
Comment 7 2016-11-03 10:48:38 PDT
Created attachment 293777 [details] Patch
WebKit Commit Bot
Comment 8 2016-11-03 10:49:56 PDT
Attachment 293777 [details] did not pass style-queue: ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:77: 'childAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:91: 'linkedUIElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:185: 'selectedRowAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:187: 'disclosedRowAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:188: 'rowAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:191: 'ariaOwnsElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:192: 'ariaFlowToElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:193: 'ariaControlsElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:249: 'textMarkerForIndex' is incorrectly named. It should be named 'protector' or 'protectedInt'. [readability/naming/protected] [4] Total errors found: 9 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Michael Catanzaro
Comment 9 2016-11-03 11:01:48 PDT
Created attachment 293781 [details] Patch
WebKit Commit Bot
Comment 10 2016-11-03 11:03:36 PDT
Attachment 293781 [details] did not pass style-queue: ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:77: 'childAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:91: 'linkedUIElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:185: 'selectedRowAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:187: 'disclosedRowAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:188: 'rowAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:191: 'ariaOwnsElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:192: 'ariaFlowToElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:193: 'ariaControlsElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:249: 'textMarkerForIndex' is incorrectly named. It should be named 'protector' or 'protectedInt'. [readability/naming/protected] [4] Total errors found: 9 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Michael Catanzaro
Comment 11 2016-11-03 11:04:06 PDT
Comment on attachment 293781 [details] Patch I fixed the GTK+ build, it just needed to use .ptr() to convert Refs to RefPtrs in a couple ternary statements. Hopefully that will fix EFL too. In AccessibilityUIElementIOS.mm you've replaced a few 0s with nullptrs, but missed several, and left one nil. I'd either change all of them or none of them. Other than the risk of breaking !HAVE(ACCESSIBILITY), it looks straightforward. Let's see if Bugzilla lets me give r+ to myself.
WebKit Commit Bot
Comment 12 2016-11-03 11:50:08 PDT
Comment on attachment 293781 [details] Patch Clearing flags on attachment: 293781 Committed r208338: <http://trac.webkit.org/changeset/208338>
WebKit Commit Bot
Comment 13 2016-11-03 11:50:13 PDT
All reviewed patches have been landed. Closing bug.
Gyuyoung Kim
Comment 14 2016-11-03 18:07:24 PDT
(In reply to comment #11) > Comment on attachment 293781 [details] > Patch > > I fixed the GTK+ build, it just needed to use .ptr() to convert Refs to > RefPtrs in a couple ternary statements. Hopefully that will fix EFL too. Thanks, Michael ! And sorry for too late reply.
Note You need to log in before you can comment on or make changes to this bug.