Bug 164345

Summary: MarkedSpace should have specialized size classes for popular engine objects.
Product: WebKit Reporter: Andreas Kling <kling>
Component: JavaScriptCoreAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, keith_miller, mark.lam, msaboff, saam
Priority: P2 Keywords: Performance
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andreas Kling
Reported 2016-11-02 15:50:16 PDT
The four chunkiest memory hogs in JSC are FunctionCodeBlock, FunctionExecutable, UnlinkedFunctionCodeBlock and UnlinkedFunctionExecutable. Let's inject size classes for their exact sizes to improve space utilization.
Attachments
Patch (3.04 KB, patch)
2016-11-02 15:51 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch (3.47 KB, patch)
2016-11-02 16:43 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2016-11-02 15:51:12 PDT
Created attachment 293703 [details] Patch
Filip Pizlo
Comment 2 2016-11-02 16:10:54 PDT
Comment on attachment 293703 [details] Patch Shouldn't this have a sedum step to make sure that you didn't add the same size twice?
Andreas Kling
Comment 3 2016-11-02 16:23:48 PDT
Comment on attachment 293703 [details] Patch Oh, yeah.
Andreas Kling
Comment 4 2016-11-02 16:43:14 PDT
Created attachment 293715 [details] Patch Deduplicate the list of size classes.
Andreas Kling
Comment 5 2016-11-02 17:23:46 PDT
Comment on attachment 293715 [details] Patch Thanks Filip!
WebKit Commit Bot
Comment 6 2016-11-02 17:47:39 PDT
Comment on attachment 293715 [details] Patch Clearing flags on attachment: 293715 Committed r208317: <http://trac.webkit.org/changeset/208317>
WebKit Commit Bot
Comment 7 2016-11-02 17:47:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.