Bug 164338 – Add TCP server to webkitpy for on device testing

• Component: Tools / Tests
• Status: RESOLVED INVALID

[Jonathan Bedard]

In order to test on device, a TCP connection will be opened between device and host.  This adds the TCP server which will run on the host into webkitpy.

[Jonathan Bedard]

Created attachment 293692 [details]
Patch

[Jonathan Bedard]

https://bugs.webkit.org/show_bug.cgi?id=164344 contains the client-side of this server.

Note that this patch does not use the TCP server, it simply implements it.

[Dean Johnson]

Comment on attachment 293692 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293692&action=review

Gave some feedback where possible - I'm probably not the best candidate for reviewing such low level interactions. Great work on this!

> Tools/Scripts/webkitpy/common/relayserver.py:58
> +            bound = False

The loop here could be rewritten for conciseness as follows:

upper_bound = PORT_RANGE[1] - PORT_RANGE[0]
for port in range(self._port, self._port + upper_bound):
    try:
        self._socket.bind((self._host, port))
        self._port = port
        break
    except socket.error as msg:
        pass
else: # This condition gets hit if you never break from a for loop
    raise Exception('Ran out of ports to try to bind to for the TCP server.)

I would also recommend 'return'ing after the binding the port in `if port`. Then you can remove the else statement too.

> Tools/Scripts/webkitpy/common/relayserver.py:177
> +            return str()

Generally speaking you should return '' over str().

[Jonathan Bedard]

Created attachment 293905 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/29201285>

[Jonathan Bedard]

Created attachment 294942 [details]
Patch

[Jonathan Bedard]

Using a different approach.