Bug 164284

Summary:

[Tables] Simplified layout skips captions.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, Hironori.Fujii, kondapallykalyan

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=187903

Bug Depends on:

Bug Blocks:

162834

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews101 for mac-yosemite	none
Patch	none
Archive of layout-test-results from ews101 for mac-yosemite	none
Archive of layout-test-results from ews107 for mac-yosemite-wk2	none
Archive of layout-test-results from ews116 for mac-yosemite	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
Patch	none

zalan

Reported 2016-11-01 12:19:23 PDT

see LayoutTests/fast/regions/table-caption-as-region.html

Attachments
Patch (5.66 KB, text/plain) 2016-11-01 12:52 PDT, zalan	no flags	Details
Archive of layout-test-results from ews101 for mac-yosemite (792.31 KB, application/zip) 2016-11-01 13:12 PDT, Build Bot	no flags	Details
Patch (6.46 KB, patch) 2016-11-01 15:06 PDT, zalan	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-yosemite (1005.44 KB, application/zip) 2016-11-01 16:02 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.09 MB, application/zip) 2016-11-01 16:09 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-yosemite (1.54 MB, application/zip) 2016-11-01 16:19 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (6.75 MB, application/zip) 2016-11-01 16:22 PDT, Build Bot	no flags	Details
Patch (6.19 KB, patch) 2016-11-01 21:50 PDT, zalan	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

zalan

Comment 1 2016-11-01 12:52:56 PDT

Created attachment 293570 [details] Patch

Build Bot

Comment 2 2016-11-01 13:12:36 PDT

Comment on attachment 293570 [details] Patch Attachment 293570 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2445502 Number of test failures exceeded the failure limit.

Build Bot

Comment 3 2016-11-01 13:12:39 PDT

Created attachment 293581 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5

zalan

Comment 4 2016-11-01 15:06:08 PDT

Created attachment 293601 [details] Patch

Dave Hyatt

Comment 5 2016-11-01 15:19:31 PDT

Comment on attachment 293601 [details] Patch r=me

Build Bot

Comment 6 2016-11-01 16:02:30 PDT

Comment on attachment 293601 [details] Patch Attachment 293601 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2446572 Number of test failures exceeded the failure limit.

Build Bot

Comment 7 2016-11-01 16:02:34 PDT

Created attachment 293611 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 8 2016-11-01 16:09:37 PDT

Comment on attachment 293601 [details] Patch Attachment 293601 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2446625 Number of test failures exceeded the failure limit.

Build Bot

Comment 9 2016-11-01 16:09:41 PDT

Created attachment 293613 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 10 2016-11-01 16:19:31 PDT

Comment on attachment 293601 [details] Patch Attachment 293601 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2446640 Number of test failures exceeded the failure limit.

Build Bot

Comment 11 2016-11-01 16:19:36 PDT

Created attachment 293614 [details] Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 12 2016-11-01 16:21:59 PDT

Comment on attachment 293601 [details] Patch Attachment 293601 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2446634 Number of test failures exceeded the failure limit.

Build Bot

Comment 13 2016-11-01 16:22:02 PDT

Created attachment 293615 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Said Abou-Hallawa

Comment 14 2016-11-01 16:24:04 PDT

Comment on attachment 293601 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293601&action=review > Source/WebCore/rendering/RenderTable.cpp:404 > +void RenderTable::layoutCaptions(CaptionSides currentCaptionSides) You can make currentCaptionSides of type OptionSet<ECaptionSide>.

zalan

Comment 15 2016-11-01 21:50:51 PDT

Created attachment 293638 [details] Patch

WebKit Commit Bot

Comment 16 2016-11-02 07:20:19 PDT

Comment on attachment 293638 [details] Patch Clearing flags on attachment: 293638 Committed r208281: <http://trac.webkit.org/changeset/208281>

WebKit Commit Bot

Comment 17 2016-11-02 07:20:23 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.