Bug 164275

Summary: We should not pop from an empty stack in the Wasm function parser.
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: JavaScriptCoreAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Keith Miller
Reported 2016-11-01 10:05:32 PDT
...
Attachments
Patch (8.42 KB, patch)
2016-11-01 19:59 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (8.17 KB, patch)
2016-11-02 09:15 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-11-01 19:59:18 PDT
Created attachment 293635 [details] Patch
JF Bastien
Comment 2 2016-11-02 09:12:02 PDT
Comment on attachment 293635 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293635&action=review lgtm with one nit. > Source/JavaScriptCore/wasm/WasmFunctionParser.h:447 > + m_context.setErrorMessage(makeString("Attempted to use an stack value when none existed stack in ")); "when none existed stack in" sounds weird. Break after "existed"?
Keith Miller
Comment 3 2016-11-02 09:15:29 PDT
Comment on attachment 293635 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293635&action=review >> Source/JavaScriptCore/wasm/WasmFunctionParser.h:447 >> + m_context.setErrorMessage(makeString("Attempted to use an stack value when none existed stack in ")); > > "when none existed stack in" sounds weird. Break after "existed"? Yeah, idk what I was thinking there. I also don't need that makeString.
Keith Miller
Comment 4 2016-11-02 09:15:44 PDT
Created attachment 293663 [details] Patch
Filip Pizlo
Comment 5 2016-11-02 10:08:14 PDT
Comment on attachment 293663 [details] Patch Consider using Optional<ExpressionType>.
WebKit Commit Bot
Comment 6 2016-11-02 10:51:20 PDT
Comment on attachment 293663 [details] Patch Clearing flags on attachment: 293663 Committed r208290: <http://trac.webkit.org/changeset/208290>
WebKit Commit Bot
Comment 7 2016-11-02 10:51:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.