Bug 164272

Summary: Add logging for "WebKit encountered an internal error" messages
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebKit2Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, barraclough, bfulgham, cdumez, cgarcia, commit-queue, joepeck, koivisto, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari 10   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 164333    
Attachments:
Description Flags
Patch v1
none
Patch v2 none

David Kilzer (:ddkilzer)
Reported 2016-11-01 07:55:02 PDT
Add logging for "WebKit encountered an internal error" messages.
Attachments
Patch v1 (9.88 KB, patch)
2016-11-01 08:41 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Patch v2 (9.89 KB, patch)
2016-11-01 13:38 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2016-11-01 07:55:18 PDT
<rdar://problem/28460265>
David Kilzer (:ddkilzer)
Comment 2 2016-11-01 07:55:53 PDT
<rdar://problem/28546064>
David Kilzer (:ddkilzer)
Comment 3 2016-11-01 08:41:47 PDT
Created attachment 293554 [details] Patch v1
Brent Fulgham
Comment 4 2016-11-01 10:15:38 PDT
Comment on attachment 293554 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=293554&action=review Looks good to me, but we need a WK2 reviewer. > Source/WebKit2/WebProcess/Network/WebLoaderStrategy.cpp:345 > + if (WebCore::Page* corePage = webPage->corePage()) I suggest "auto* corePage ="
David Kilzer (:ddkilzer)
Comment 5 2016-11-01 13:38:50 PDT
Created attachment 293583 [details] Patch v2
David Kilzer (:ddkilzer)
Comment 6 2016-11-01 13:39:20 PDT
(In reply to comment #5) > Created attachment 293583 [details] > Patch v2 Used more 'auto'.
WebKit Commit Bot
Comment 7 2016-11-02 10:00:31 PDT
Comment on attachment 293583 [details] Patch v2 Clearing flags on attachment: 293583 Committed r208286: <http://trac.webkit.org/changeset/208286>
WebKit Commit Bot
Comment 8 2016-11-02 10:00:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.