Bug 164272

Summary: Add logging for "WebKit encountered an internal error" messages
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebKit2Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, barraclough, bfulgham, cdumez, cgarcia, commit-queue, joepeck, koivisto, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari 10   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 164333    
Attachments:
Description Flags
Patch v1
none
Patch v2 none

Description David Kilzer (:ddkilzer) 2016-11-01 07:55:02 PDT 
Add logging for "WebKit encountered an internal error" messages.
Comment 1 David Kilzer (:ddkilzer) 2016-11-01 07:55:18 PDT 
<rdar://problem/28460265>
Comment 2 David Kilzer (:ddkilzer) 2016-11-01 07:55:53 PDT 
<rdar://problem/28546064>
Comment 3 David Kilzer (:ddkilzer) 2016-11-01 08:41:47 PDT 
Created attachment 293554 [details]
Patch v1
Comment 4 Brent Fulgham 2016-11-01 10:15:38 PDT 
Comment on attachment 293554 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=293554&action=review

Looks good to me, but we need a WK2 reviewer.

> Source/WebKit2/WebProcess/Network/WebLoaderStrategy.cpp:345
> +        if (WebCore::Page* corePage = webPage->corePage())

I suggest "auto* corePage ="
Comment 5 David Kilzer (:ddkilzer) 2016-11-01 13:38:50 PDT 
Created attachment 293583 [details]
Patch v2
Comment 6 David Kilzer (:ddkilzer) 2016-11-01 13:39:20 PDT 
(In reply to comment #5)
> Created attachment 293583 [details]
> Patch v2

Used more 'auto'.
Comment 7 WebKit Commit Bot 2016-11-02 10:00:31 PDT 
Comment on attachment 293583 [details]
Patch v2

Clearing flags on attachment: 293583

Committed r208286: <http://trac.webkit.org/changeset/208286>
Comment 8 WebKit Commit Bot 2016-11-02 10:00:36 PDT 
All reviewed patches have been landed.  Closing bug.