Bug 164270

Summary: [GTK] Failed to generate GeoClue2Interface files.
Product: WebKit Reporter: Hyowon Kim <hw1008.kim>
Component: WebKitGTKAssignee: Hyowon Kim <hw1008.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, commit-queue, mcatanzaro
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Hyowon Kim
Reported 2016-11-01 06:01:40 PDT
geoclue2 uses gdbus-codegen to generate codes for D-Bus Interfaces. But libgeoclue-2-dev doesn't contain D-Bus introspection XML files (org.freedesktop.GeoClue2.xml). So the below command in WebCore/PlatformGtk.cmake is not working properly. add_custom_command( OUTPUT ${DERIVED_SOURCES_WEBCORE_DIR}/Geoclue2Interface.c ${DERIVED_SOURCES_WEBCORE_DIR}/Geoclue2Interface.h COMMAND gdbus-codegen --interface-prefix org.freedesktop.GeoClue2. --c-namespace Geoclue --generate-c- code ${DERIVED_SOURCES_WEBCORE_DIR}/Geoclue2Interface ${GEOCLUE_DBUS_INTERFACE} ) Adding geoclue-2.0 package into install-dependencies seems to be needed.
Attachments
Patch (1.19 KB, patch)
2016-11-01 06:10 PDT, Hyowon Kim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hyowon Kim
Comment 1 2016-11-01 06:10:11 PDT
Created attachment 293550 [details] Patch
WebKit Commit Bot
Comment 2 2016-11-01 06:51:39 PDT
Comment on attachment 293550 [details] Patch Clearing flags on attachment: 293550 Committed r208221: <http://trac.webkit.org/changeset/208221>
WebKit Commit Bot
Comment 3 2016-11-01 06:51:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.