Bug 164268

Summary:

Web Inspector: Fix double remove of ResourceCollection if type changes

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, buildbot, commit-queue, joepeck, mattbaker, nvasilyev, rniwa, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews101 for mac-yosemite	none
Archive of layout-test-results from ews105 for mac-yosemite-wk2	none
Archive of layout-test-results from ews117 for mac-yosemite	none
Patch	none

Devin Rousso

Reported 2016-11-01 00:48:18 PDT

If a ResourceCollection is created without a type, and a Resource object is added to it, a sub-collection (also a ResourceCollection) is created for that specific type and stored in a Map. If the type on that Resource changes, the `WebInspector.Resource.Event.TypeDidChange` event listeners for both the "parent" collection and the sub-collection will be fired, and both attempt to remove the resource from the sub-collection of that type: - The "parent" tries to add it to the sub-collection of the new type (creating one if it does not exist) and remove it from the sub-collection of the old type - The sub-collection of the old type tries to remove it from itself since it has a specified type, and changing types means that it no longer matches

Attachments
Patch (2.16 KB, patch) 2016-11-01 00:51 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-yosemite (976.02 KB, application/zip) 2016-11-01 01:51 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.03 MB, application/zip) 2016-11-01 01:55 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews117 for mac-yosemite (1.76 MB, application/zip) 2016-11-01 02:13 PDT, Build Bot	no flags	Details
Patch (3.37 KB, patch) 2016-11-01 10:27 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2016-11-01 00:48:33 PDT

<rdar://problem/29040483>

Devin Rousso

Comment 2 2016-11-01 00:51:54 PDT

Created attachment 293536 [details] Patch

Build Bot

Comment 3 2016-11-01 01:51:16 PDT

Comment on attachment 293536 [details] Patch Attachment 293536 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2425667 New failing tests: inspector/unit-tests/resource-collection.html

Build Bot

Comment 4 2016-11-01 01:51:19 PDT

Created attachment 293538 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 5 2016-11-01 01:55:08 PDT

Comment on attachment 293536 [details] Patch Attachment 293536 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2425671 New failing tests: inspector/unit-tests/resource-collection.html

Build Bot

Comment 6 2016-11-01 01:55:11 PDT

Created attachment 293540 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 7 2016-11-01 02:12:59 PDT

Comment on attachment 293536 [details] Patch Attachment 293536 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2425692 New failing tests: inspector/unit-tests/resource-collection.html

Build Bot

Comment 8 2016-11-01 02:13:02 PDT

Created attachment 293541 [details] Archive of layout-test-results from ews117 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5

Matt Baker

Comment 9 2016-11-01 09:31:35 PDT

Comment on attachment 293536 [details] Patch r- because of resource-collection.html failure. Maybe test expectations need updating?

Devin Rousso

Comment 10 2016-11-01 10:27:02 PDT

Created attachment 293557 [details] Patch

Joseph Pecoraro

Comment 11 2016-11-01 11:10:46 PDT

Comment on attachment 293557 [details] Patch r=me

WebKit Commit Bot

Comment 12 2016-11-01 12:07:44 PDT

Comment on attachment 293557 [details] Patch Clearing flags on attachment: 293557 Committed r208234: <http://trac.webkit.org/changeset/208234>

WebKit Commit Bot

Comment 13 2016-11-01 12:07:50 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.