Bug 16424 – Enable auto-scroll in page by mouse middle click

• Component: New Bugs
• Status: RESOLVED FIXED

[Louise]

Is there a reason for not having this feature?
Since Firefox and Opera supports it, seems reasonablt for webkit to have it too.

I couldn't find any bug concerning this problem so I'm going to file one myself.
Please tell me if this is not an appropriate place to talk about this.
thanks.

[Adam Roben (:aroben)]

<rdar://5603777>

[Robert Blaut]

There is no reason to keeping enhancement requests in an unconfirmed state.

[Maxime Britto]

Created attachment 21848 [details]
Add the feature without the icon yet

This patch adds the requested feature. I also need to work on the icon which should be displayed at the original middle click location (and stay still while scrolling) and will be issued in a future patch.

[Dave Hyatt]

Comment on attachment 21848 [details]
Add the feature without the icon yet

This patch contains tabs.  Can you re-attach a tab-free version?

[Dave Hyatt]

The pan scroll shouldn't trigger if you can't scroll the clicked area.

Firefox pan scrolls only documents, and does not pan scroll overflow:auto sections.  This honestly looks like a bug to me.  Your code is doing the same thing, but I think overflow:auto sections should pan scroll....

You might want to test what IE does with overflow sections on Windows when it pan scrolls.

[Adam Roben (:aroben)]

Comment on attachment 21848 [details]
Add the feature without the icon yet

+	else if (mouseEvent.button() == MiddleButton && !mev.isOverLink()) {
+		startPanScroll();
+		invalidateClick();
+        return false;

I don't think !mev.isOverLink() is a good enough check here. You probably wouldn't want the pan to occur when you middle-click on a button.

In general, we may not want the pan to occur if event.preventDefault() is called. We should test in Firefox and IE to see if calling event.preventDefault() on a middle-click event prevents the pan from occurring. We should match their behavior in this regard.

[Maxime Britto]

Created attachment 22057 [details]
patch attempt

Works only on windows.
Icon added.

[Maxime Britto]

Comment on attachment 22057 [details]
patch attempt

I noticed some cosmetic changes so don't review this one, I'm preparing a new one.

[Maxime Britto]

Created attachment 22068 [details]
patch

Made some functional and cosmetic corrections.

[Maxime Britto]

Created attachment 22159 [details]
new patch

This version fix 2 problems I found with the previous one :
- It was possible to trigger multiple panScroll on frameset (one on each frame)
- It was possible to trigger the panScroll event when the object was not scrollable

[Maxime Britto]

Fixed in r35083

[Robert Blaut]

Why the patch is not reviewed?

[Maxime Britto]

It has been reviewed by email this afternoon by Adele Peterson. She will mark it reviewed tomorrow on bugzilla I guess.

[Adele Peterson]

Comment on attachment 22159 [details]
new patch

I reviewed this yesterday.