Bug 164204 – [GTK] Plugin process crash in WebKit::NetscapePluginX11::visibilityDidChange with evince browser plugin

• Component: Plug-ins
• Status: RESOLVED FIXED

[Michael Catanzaro]

An Evince browser plugin crash. Full backtrace downstream as usual. Truncated backtrace:

Thread no. 1 (10 frames)
 #0 gdk_window_has_impl at gdkwindow.c:626
 #1 _gdk_window_has_impl at gdkwindow.c:627
 #2 gdk_x11_window_get_xid at gdkwindow-x11.c:5542
 #3 WebKit::NetscapePluginX11::visibilityDidChange at /usr/src/debug/webkitgtk-2.12.3/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:267
 #4 WebKit::PluginControllerProxy::visibilityDidChange at /usr/src/debug/webkitgtk-2.12.3/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:437
 #5 IPC::callMemberFunctionImpl<WebKit::PluginControllerProxy, void (WebKit::PluginControllerProxy::*)(bool), std::tuple<bool>, 0ul>(WebKit::PluginControllerProxy*, void (WebKit::PluginControllerProxy::*)(bool), std::tuple<bool>&&, std::index_sequence<0ul>) at /usr/src/debug/webkitgtk-2.12.3/Source/WebKit2/Platform/IPC/HandleMessage.h:16
 #6 IPC::callMemberFunction<WebKit::PluginControllerProxy, void (WebKit::PluginControllerProxy::*)(bool), std::tuple<bool>, std::make_index_sequence<1ul> >(std::tuple<bool>&&, WebKit::PluginControllerProxy*, void (WebKit::PluginControllerProxy::*)(bool)) at /usr/src/debug/webkitgtk-2.12.3/Source/WebKit2/Platform/IPC/HandleMessage.h:22
 #7 IPC::handleMessage<Messages::PluginControllerProxy::MutedStateChanged, WebKit::PluginControllerProxy, void (WebKit::PluginControllerProxy::*)(bool)> at /usr/src/debug/webkitgtk-2.12.3/Source/WebKit2/Platform/IPC/HandleMessage.h:92
 #8 WebKit::PluginControllerProxy::didReceivePluginControllerProxyMessage at /usr/src/debug/webkitgtk-2.12.3/x86_64-redhat-linux-gnu/DerivedSources/WebKit2/PluginControllerProxyMessageReceiver.cpp:53
 #9 WebKit::WebProcessConnection::didReceiveMessage at /usr/src/debug/webkitgtk-2.12.3/Source/WebKit2/PluginProcess/WebProcessConnection.cpp:141

[Michael Catanzaro]

Here's a second one: https://bugzilla.gnome.org/show_bug.cgi?id=762838

That one is surely an evince problem though.

[Carlos Garcia Campos]

For some reason the plug is not embedded when NetscapePluginX11::visibilityDidChange is called. Do you remember if you were doing any tab drag an drop when this happened? Or was it after closing the tab?

[Michael Catanzaro]

I don't remember, unfortunately I originally reported this in June and it just didn't make it upstream.

[Carlos Garcia Campos]

Created attachment 293430 [details]
Speculative fix

[WebKit Commit Bot]

This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".

[Carlos Garcia Campos]

Committed r208272: <http://trac.webkit.org/changeset/208272>