Bug 164181

Summary: SVG clip-path references can clip out later content
Product: WebKit Reporter: Ryan.d.labar
Component: SVGAssignee: Philip Rogers <pdr>
Status: RESOLVED FIXED    
Severity: Normal CC: chrishtr, commit-queue, dino, esprehn+autocc, glenn, kondapallykalyan, pdr, sabouhallawa, simon.fraser, vincent, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: Safari 10   
Hardware: Mac   
OS: macOS 10.12   
Attachments:
Description Flags
Patch
none
PatchWithUpdatedChangeLog
none
PatchWithUpdatedChangeLog2 none

Ryan.d.labar
Reported 2016-10-29 09:30:34 PDT
http://codepen.io/ryan_labar/pen/KgLNyx Also seems to happen in mobile safari Using CSS clip-path with an SVG with objectBoundingBox only displays first item and hides the rest or inconsistently displays them.
Attachments
Patch (4.24 KB, patch)
2017-02-06 21:46 PST, Philip Rogers 		no flags
DetailsFormatted DiffDiff
PatchWithUpdatedChangeLog (4.32 KB, patch)
2017-02-09 17:28 PST, Philip Rogers 		no flags
DetailsFormatted DiffDiff
PatchWithUpdatedChangeLog2 (4.32 KB, patch)
2017-02-09 17:44 PST, Philip Rogers 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2016-10-29 13:45:04 PDT
<rdar://problem/29000405>
vincent
Comment 2 2017-01-31 13:41:59 PST
Not sure it's only related to objectBoundingBox, but I opened this Chromium bug a while ago that seems related: https://bugs.chromium.org/p/chromium/issues/detail?id=391291&thanks=391291&ts=1404397995 Also, a simple testcase: http://jsbin.com/bipokocegi/edit?html,css,output Hope this could be fixed soon
Philip Rogers
Comment 3 2017-02-06 21:46:53 PST
Created attachment 300787 [details] Patch
Philip Rogers
Comment 4 2017-02-09 15:53:27 PST
Ping for review?
Said Abou-Hallawa
Comment 5 2017-02-09 17:06:42 PST
Comment on attachment 300787 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300787&action=review > Source/WebCore/ChangeLog:9 > + clipping codepath) so we need to ensure RenderLayer::setupClipPath saves and restores RenderLayer::setupClipPath() saves the context and RenderLayer::paintLayerContents() restores back if RenderLayer::setupClipPath() returns true. How about something like that: "...we need to ensure RenderLayer::setupClipPath() saves the context and its caller restores it back so later content is not clipped as well."
Philip Rogers
Comment 6 2017-02-09 17:28:10 PST
Created attachment 301111 [details] PatchWithUpdatedChangeLog
Philip Rogers
Comment 7 2017-02-09 17:44:59 PST
Created attachment 301114 [details] PatchWithUpdatedChangeLog2
WebKit Commit Bot
Comment 8 2017-02-09 19:29:14 PST
Comment on attachment 301114 [details] PatchWithUpdatedChangeLog2 Clearing flags on attachment: 301114 Committed r212038: <http://trac.webkit.org/changeset/212038>
WebKit Commit Bot
Comment 9 2017-02-09 19:29:18 PST
All reviewed patches have been landed. Closing bug.
Ryan.d.labar
Comment 10 2017-02-11 17:19:58 PST
(In reply to comment #9) > All reviewed patches have been landed. Closing bug. You are all heros!
Note You need to log in before you can comment on or make changes to this bug.