Bug 164124

Summary: New CSS Parser should use Colors not RGBA32s
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Dean Jackson
Reported 2016-10-28 06:05:41 PDT
New CSS Parser should use Colors not RGBA32s
Attachments
Patch (8.79 KB, patch)
2016-10-28 06:13 PDT, Dean Jackson 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2016-10-28 06:07:38 PDT
<rdar://problem/29000373>
Dean Jackson
Comment 2 2016-10-28 06:13:44 PDT
Created attachment 293148 [details] Patch
Darin Adler
Comment 3 2016-10-28 11:04:15 PDT
Comment on attachment 293148 [details] Patch So annoying how Color is intrinsically optional, and so when a function returns Color you can’t tell whether it’s optional or not.
Dean Jackson
Comment 4 2016-10-28 11:57:21 PDT
Committed r208060: <http://trac.webkit.org/changeset/208060>
Note You need to log in before you can comment on or make changes to this bug.