Bug 164092

Summary: Web Inspector: Creating a new pseudo-selector in the Styles sidebar doesn't work on first attempt
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, hi, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Animated GIF] Bug
none
Patch
timothy: review+
Patch none

Nikita Vasilyev
Reported 2016-10-27 16:10:29 PDT
Created attachment 293074 [details] [Animated GIF] Bug 1. Inspect <body> on this page. 2. At the bottom of the styles sidebar press "+" icon. 3. Click on the selector name ("body") 4. Append "::after". 5. Press Tab Expected: The selector remains to be "body::after". Actual: The selector reverts to "body". Notes: Renaming "body" to "body::after" second time works as expected.
Attachments
[Animated GIF] Bug (103.72 KB, image/gif)
2016-10-27 16:10 PDT, Nikita Vasilyev 		no flags
Details
Patch (8.21 KB, patch)
2016-10-28 15:44 PDT, Devin Rousso 		timothy: review+
DetailsFormatted DiffDiff
Patch (8.26 KB, patch)
2016-11-01 19:05 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2016-10-28 15:44:37 PDT
Created attachment 293233 [details] Patch
Timothy Hatcher
Comment 2 2016-11-01 14:55:59 PDT
Comment on attachment 293233 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293233&action=review > Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js:580 > + for (let element of this._selectorElements) { > + let {top, right, bottom, left} = element.getBoundingClientRect(); > + if (event.clientX >= left && event.clientX <= right && event.clientY >= top && event.clientY <= bottom) { > + this._selectorInput.title = element.title; > + return; > + } > + } This could use a comment.
Radar WebKit Bug Importer
Comment 3 2016-11-01 16:50:46 PDT
<rdar://problem/29055344>
Devin Rousso
Comment 4 2016-11-01 19:05:35 PDT
Created attachment 293631 [details] Patch
WebKit Commit Bot
Comment 5 2016-11-01 19:41:53 PDT
Comment on attachment 293631 [details] Patch Clearing flags on attachment: 293631 Committed r208270: <http://trac.webkit.org/changeset/208270>
WebKit Commit Bot
Comment 6 2016-11-01 19:41:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.