Bug 164008 – Implement WebGL2RenderingContext::copyBufferSubData()

• Component: WebGL
• Status: RESOLVED FIXED

[Myles C. Maxfield]

Implement WebGL2RenderingContext::copyBufferSubData()

[Myles C. Maxfield]

Created attachment 292883 [details]
Patch

[Myles C. Maxfield]

Created attachment 293276 [details]
Patch

[Myles C. Maxfield]

Created attachment 293903 [details]
Patch

[Dean Jackson]

Comment on attachment 293903 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293903&action=review

> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:179
> +        synthesizeGLError(GraphicsContext3D::INVALID_OPERATION, "copyBufferSubData", "offset < 0");

This seems like the wrong message.

> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:183
> +        synthesizeGLError(GraphicsContext3D::INVALID_VALUE, "copyBufferSubData", "offset < 0");

This one is accurate :)

I wonder why these are not uints in the API?

> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:189
> +        synthesizeGLError(GraphicsContext3D::INVALID_VALUE, "copyBufferSubData", "offset < 0");

This one is also wrong.

> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:194
> +    if (!this->isErrorGeneratedOnOutOfBoundsAccesses()) {
> +        if (!writeBuffer->associateCopyBufferSubData(*readBuffer, static_cast<GC3Dintptr>(readOffset), static_cast<GC3Dintptr>(writeOffset), static_cast<GC3Dsizeiptr>(size))) {
> +            this->synthesizeGLError(GraphicsContext3D::INVALID_VALUE, "copyBufferSubData", "offset out of range");

What don't I understand here? You're only doing the associate check if errors are NOT generated?

[Myles C. Maxfield]

Comment on attachment 293903 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293903&action=review

>> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:194
>> +            this->synthesizeGLError(GraphicsContext3D::INVALID_VALUE, "copyBufferSubData", "offset out of range");
> 
> What don't I understand here? You're only doing the associate check if errors are NOT generated?

https://bugs.webkit.org/show_bug.cgi?id=164418

[Myles C. Maxfield]

Created attachment 293904 [details]
Patch for committing

[WebKit Commit Bot]

Comment on attachment 293904 [details]
Patch for committing

Rejecting attachment 293904 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 293904, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/2462991

[Build Bot]

Comment on attachment 293904 [details]
Patch for committing

Attachment 293904 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2462997

New failing tests:
inspector/sampling-profiler/call-frame-with-dom-functions.html

[Build Bot]

Created attachment 293914 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Myles C. Maxfield]

Committed r208396: <http://trac.webkit.org/changeset/208396>