| Summary: | Add ThrowScope::release() calls at all call sites of jsMakeNontrivialString(). | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, darin, keith_miller, msaboff, saam | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Local Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Mark Lam
2016-10-25 15:17:04 PDT
Created attachment 292834 [details]
proposed patch.
Comment on attachment 292834 [details]
proposed patch.
r=me
Thanks for the review. Landed in r207851: <http://trac.webkit.org/r207851>. What’s the rule here? How can I be sure not to get this wrong in the future? Is the rule written down somewhere? (In reply to comment #4) > What’s the rule here? How can I be sure not to get this wrong in the future? > Is the rule written down somewhere? See the ChangeLog of r205569 for details on how the ExceptionScopes (ThrowScope and CatchScope) works: https://trac.webkit.org/changeset/205569/trunk/Source/JavaScriptCore/ChangeLog. We're gradually converting the code base to do the right thing. Once we've reach convergence, we'll turn on EXCEPTION_SCOPE_VERIFICATION on Debug builds. That should help us catch places where we're not doing the right thing. Lets put a copy of that somewhere else. We are going to have to follow these rules for years. |