Bug 163990

Summary: Add ThrowScope::release() calls at all call sites of jsMakeNontrivialString().
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, keith_miller, msaboff, saam
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. ggaren: review+

Mark Lam
Reported 2016-10-25 15:17:04 PDT
Patch coming.
Attachments
proposed patch. (9.48 KB, patch)
2016-10-25 15:27 PDT, Mark Lam 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2016-10-25 15:27:44 PDT
Created attachment 292834 [details] proposed patch.
Geoffrey Garen
Comment 2 2016-10-25 15:29:36 PDT
Comment on attachment 292834 [details] proposed patch. r=me
Mark Lam
Comment 3 2016-10-25 15:33:39 PDT
Thanks for the review. Landed in r207851: <http://trac.webkit.org/r207851>.
Darin Adler
Comment 4 2016-10-25 15:39:34 PDT
What’s the rule here? How can I be sure not to get this wrong in the future? Is the rule written down somewhere?
Mark Lam
Comment 5 2016-10-25 15:45:12 PDT
(In reply to comment #4) > What’s the rule here? How can I be sure not to get this wrong in the future? > Is the rule written down somewhere? See the ChangeLog of r205569 for details on how the ExceptionScopes (ThrowScope and CatchScope) works: https://trac.webkit.org/changeset/205569/trunk/Source/JavaScriptCore/ChangeLog. We're gradually converting the code base to do the right thing. Once we've reach convergence, we'll turn on EXCEPTION_SCOPE_VERIFICATION on Debug builds. That should help us catch places where we're not doing the right thing.
Darin Adler
Comment 6 2016-10-25 15:57:23 PDT
Lets put a copy of that somewhere else. We are going to have to follow these rules for years.
Note You need to log in before you can comment on or make changes to this bug.