Bug 163983

Summary: Opt-out of AVPlayer automatic sleep disabling
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: ahmad.saleem792, commit-queue, jonlee, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
eric.carlson: review+
Patch for landing none

Jer Noble
Reported 2016-10-25 14:12:32 PDT
Opt-out of AVPlayer automatic sleep disabling
Attachments
Patch (5.30 KB, patch)
2016-10-25 14:16 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (11.16 KB, patch)
2016-10-25 16:56 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (11.47 KB, patch)
2016-10-28 10:07 PDT, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch for landing (11.45 KB, patch)
2016-10-28 17:59 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2016-10-25 14:16:15 PDT
Created attachment 292818 [details] Patch
Jon Lee
Comment 2 2016-10-25 15:36:21 PDT
Comment on attachment 292818 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292818&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1053 > + if ([m_avPlayer respondsToSelector:@selector(_setPreventsSleepDuringVideoPlayback:)]) Is this check necessary?
Jer Noble
Comment 3 2016-10-25 16:56:13 PDT
Created attachment 292849 [details] Patch
Jer Noble
Comment 4 2016-10-25 16:58:13 PDT
(In reply to comment #2) > Comment on attachment 292818 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=292818&action=review > > > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1053 > > + if ([m_avPlayer respondsToSelector:@selector(_setPreventsSleepDuringVideoPlayback:)]) > > Is this check necessary? Only a preponderance of caution; since it's SPI, it's not guaranteed to exist in any particular platform.
Jon Lee
Comment 5 2016-10-26 12:42:45 PDT
rdar://problem/28496489
Jer Noble
Comment 6 2016-10-28 10:07:27 PDT
Created attachment 293168 [details] Patch
Eric Carlson
Comment 7 2016-10-28 12:24:28 PDT
Comment on attachment 293168 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293168&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1054 > + if ([m_avPlayer respondsToSelector:@selector(_setPreventsSleepDuringVideoPlayback:)]) > + [m_avPlayer _setPreventsSleepDuringVideoPlayback:player()->shouldDisableSleep()]; Nit: you can just call setShouldDisableSleep() here instead of duplicating the code.
Jer Noble
Comment 8 2016-10-28 17:59:47 PDT
Created attachment 293263 [details] Patch for landing
WebKit Commit Bot
Comment 9 2016-10-31 09:40:22 PDT
Comment on attachment 293263 [details] Patch for landing Clearing flags on attachment: 293263 Committed r208151: <http://trac.webkit.org/changeset/208151>
Ahmad Saleem
Comment 10 2022-10-10 12:15:07 PDT
This landed and didn't backed out: Link - https://github.com/WebKit/WebKit/commit/df60ebbfa340b5663a91c6f04cee23a2772bbbf5 Marking this as "RESOLVED FIXED".
Note You need to log in before you can comment on or make changes to this bug.